Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 173397: Allow Chromium Linux to be built with Breakpad. Enable Linux CHROME_HEADLESS ... (Closed)

Created:
11 years, 4 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)
Visibility:
Public.

Description

Allow Chromium Linux to be built with Breakpad. Enable Linux CHROME_HEADLESS support. (Try 2) TEST=none BUG=19663 Original Review URL: http://codereview.chromium.org/173095 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24378

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -69 lines) Patch
M breakpad/breakpad.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M build/common.gypi View 5 chunks +20 lines, -8 lines 0 comments Download
M chrome/app/breakpad_linux.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/app/breakpad_linux.cc View 15 chunks +74 lines, -34 lines 0 comments Download
M chrome/browser/renderer_host/render_crash_handler_host_linux.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/common/child_process_host.cc View 1 chunk +7 lines, -7 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
Original CL got reverted due to Python memory leaks on the UI Valgrind bots. Here ...
11 years, 4 months ago (2009-08-25 21:33:21 UTC) #1
agl
11 years, 4 months ago (2009-08-25 21:35:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698