Allow Chromium Linux to be built with Breakpad. Enable Linux CHROME_HEADLESS ...

chrome/common/child_process_host.cc

Index: chrome/common/child_process_host.cc
===================================================================
--- chrome/common/child_process_host.cc	(revision 24255)
+++ chrome/common/child_process_host.cc	(working copy)
@@ -145,18 +145,18 @@
 
 // static
 void ChildProcessHost::SetCrashReporterCommandLine(CommandLine* command_line) {
-#if defined(OS_POSIX)
-  if (GoogleUpdateSettings::GetCollectStatsConsent()) {
-#if defined(OS_LINUX)
+#if defined(USE_LINUX_BREAKPAD)
+  const bool unattended = (getenv("CHROME_HEADLESS") != NULL);
+  if (unattended || GoogleUpdateSettings::GetCollectStatsConsent()) {
     command_line->AppendSwitchWithValue(switches::kEnableCrashReporter,
                                         ASCIIToWide(google_update::linux_guid +
                                                     "," +
                                                     base::GetLinuxDistro()));

[Lei Zhang, 2009/08/25 21:33:21]

It turns out the call to GetLinuxDistro() caused Valgrind to check
/usr/bin/lsb_release (a python script) for memory leaks, and there were a lot of
them. So we need to wrap this code inside a #define.

Since we only have Breakpad support on Linux and Mac, and not all POSIX
platforms, I changed the #if's to be more explicit.

-#else  // !OS_LINUX
+  }
+#elif defined(OS_MACOSX)
+  if (GoogleUpdateSettings::GetCollectStatsConsent())
     command_line->AppendSwitch(switches::kEnableCrashReporter);
-#endif  // !OS_LINUX
-  }
-#endif  // OS_POSIX
+#endif  // OS_MACOSX
 }
 
 bool ChildProcessHost::CreateChannel() {