Issue 173348: Api inlining. Made some core functionality available in the api and...

Issue 173348: Api inlining. Made some core functionality available in the api and... (Closed)

Created:
11 years, 4 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Api inlining. Made some core functionality available in the api and made inline versions of some hot functions. Changed api to use internal Object pointers rather than void pointers. Speeds up getElementById by ~7%. Committed: http://code.google.com/p/v8/source/detail?r=2761

Patch Set 1 #

Total comments: 8

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+446 lines, -182 lines)			Patch
M	SConstruct	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	include/v8.h	View	29 chunks	+318 lines, -35 lines	2 comments	Download
M	src/api.h	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	src/api.cc	View	17 chunks	+75 lines, -106 lines	0 comments	Download
M	src/apiutils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/globals.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/handles.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/handles.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	5 chunks	+12 lines, -0 lines	2 comments	Download
M	src/objects-inl.h	View	4 chunks	+10 lines, -2 lines	2 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+2 lines, -1 line	2 comments	Download
M	tools/v8.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/visual_studio/debug.vsprops	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/173348/diff/1/5 File include/v8.h (right): http://codereview.chromium.org/173348/diff/1/5#newcode2731 Line 2731: kHeapObjectTag); I would align this with '(reinterpret_cast...' ...

11 years, 4 months ago (2009-08-26 06:22:20 UTC) #2

Christian Plesner Hansen

11 years, 4 months ago (2009-08-26 10:31:05 UTC) #3

http://codereview.chromium.org/173348/diff/1/10
File src/objects.h (right):

http://codereview.chromium.org/173348/diff/1/10#newcode1238
Line 1238: // other also has to.
Removed it instead.  It's pretty easy to see what's going on from the code
itself.

http://codereview.chromium.org/173348/diff/1/4
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/173348/diff/1/4#newcode88
Line 88: '-g',
Whoops!

Expand Messages | Collapse Messages