Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 173306: Force databases and localstorage to be enabled extensions. (Closed)

Created:
11 years, 4 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Force databases and localstorage to be enabled extensions. We were already doing this, this change modifies the mechanism. Before we were relying on the presence of the --enable-extensions flag, but as we are getting ready to remove that on dev, we needed something else. This forces local storage and database to be enabled on chrome-extension:// pages. Also, change the way database enabling works in general to be more like the way local storage works, just for consistency. Will remove old, unnecessary WebKit API in an upstream change. erikkay: extensions stuff dumi: database stuff jorlow: local storage stuff BUG=19511 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24841

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -15 lines) Patch
A chrome/browser/extensions/extension_storage_apitest.cc View 1 chunk +9 lines, -0 lines 1 comment Download
M chrome/browser/renderer_host/render_view_host.cc View 1 1 chunk +11 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
A chrome/test/data/extensions/api_test/storage/api_test.js View 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/storage/background.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/storage/manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/storage/tab.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +1 line, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
11 years, 4 months ago (2009-08-24 22:30:32 UTC) #1
Erik does not do reviews
LGTM http://codereview.chromium.org/173306/diff/1014/1015 File chrome/browser/extensions/extension_storage_apitest.cc (right): http://codereview.chromium.org/173306/diff/1014/1015#newcode8 Line 8: ASSERT_TRUE(RunExtensionTest("storage")) << message_; yay! http://codereview.chromium.org/173306/diff/1014/1025 File webkit/glue/webpreferences.cc ...
11 years, 4 months ago (2009-08-24 23:25:26 UTC) #2
dumi
lgtm
11 years, 4 months ago (2009-08-25 00:07:44 UTC) #3
jorlow
11 years, 4 months ago (2009-08-25 17:25:15 UTC) #4
LGTM

On Mon, Aug 24, 2009 at 5:07 PM, <dumi@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.org/173306
>

Powered by Google App Engine
This is Rietveld 408576698