Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 173296: Convert internal time format to Windows 1601 epoch on Linux & Mac.... (Closed)

Created:
11 years, 4 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), willchan no longer on Chromium, Ben Goodger (Google), Mark Mentovai
Visibility:
Public.

Description

Convert internal time format to Windows 1601 epoch on Linux & Mac. Although we represent time internally starting from 1601, there are still things like time explosion that will not work before the year 1900. This limitation is the same as it was previously. BUG=14734 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24417

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -62 lines) Patch
M base/time.h View 1 chunk +9 lines, -0 lines 0 comments Download
M base/time_mac.cc View 1 2 3 2 chunks +24 lines, -10 lines 0 comments Download
M base/time_posix.cc View 1 2 3 6 chunks +34 lines, -42 lines 0 comments Download
M base/time_unittest.cc View 1 2 3 4 5 3 chunks +26 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/history/history_database.h View 1 4 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/history/history_database.cc View 4 chunks +48 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/profiles/typical_history/Default/History View Binary file 0 comments Download
M net/base/cookie_monster_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
brettw
This is the follow-on for: http://codereview.chromium.org/150097 CC's are copied from that review. Dean: please review ...
11 years, 4 months ago (2009-08-24 20:57:10 UTC) #1
Dean McNamee
I don't exactly understand what we're upgrading and what we're not (within the history system). ...
11 years, 4 months ago (2009-08-24 21:16:23 UTC) #2
brettw
Other things this doesn't affect: favicon and thumbnail dates. This will cause favicons to be ...
11 years, 4 months ago (2009-08-24 21:31:56 UTC) #3
brettw
Good point about the bookmarks sync. They don't use the dates for anything, but they ...
11 years, 4 months ago (2009-08-24 22:08:09 UTC) #4
brettw
Reasoning for the History Indices: The full text search databases are easy to update, but ...
11 years, 4 months ago (2009-08-24 22:09:23 UTC) #5
Dean McNamee
Does the FTS ever get rebuilt? On Mon, Aug 24, 2009 at 3:09 PM, <brettw@chromium.org> ...
11 years, 4 months ago (2009-08-24 22:14:23 UTC) #6
brettw
On 2009/08/24 22:14:23, Dean McNamee wrote: > Does the FTS ever get rebuilt? What can ...
11 years, 4 months ago (2009-08-24 22:37:49 UTC) #7
brettw
Scott: can you review the bookmarks change? New patch up. This migrates bookmark times. Downloads ...
11 years, 4 months ago (2009-08-24 23:42:08 UTC) #8
sky
LGTM
11 years, 4 months ago (2009-08-25 00:45:44 UTC) #9
Amanda Walker
mac changes LGTM
11 years, 4 months ago (2009-08-25 00:54:44 UTC) #10
Dean McNamee
LGTM. How do we decide when to pull out the bookmark upgrading code? On 2009/08/25 ...
11 years, 4 months ago (2009-08-25 18:37:17 UTC) #11
brettw
11 years, 4 months ago (2009-08-25 23:04:20 UTC) #12
On 2009/08/25 18:37:17, Dean McNamee wrote:
> LGTM.
> 
> How do we decide when to pull out the bookmark upgrading code?

I filed http://code.google.com/p/chromium/issues/detail?id=20264 for this.

Powered by Google App Engine
This is Rietveld 408576698