Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 173260: Some code style cleanup under src/app. (Closed)

Created:
11 years, 4 months ago by tfarina (gmail-do not use)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Some code style cleanup under src/app. BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24859

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment line fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
MM app/app_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/canvas.h View 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/color_utils.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M app/gfx/color_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/favicon_size.h View 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/icon_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M app/gfx/insets.h View 1 chunk +2 lines, -2 lines 0 comments Download
M app/gfx/path.h View 1 chunk +1 line, -1 line 0 comments Download
M app/resource_bundle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M app/resource_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/win_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina (gmail-do not use)
Hi Mohamed, this is just a little style fix, could you take a look, please?
11 years, 4 months ago (2009-08-24 00:22:20 UTC) #1
Mark Mentovai
Quick drive-by nit. http://codereview.chromium.org/173260/diff/1/5 File app/gfx/color_utils.h (right): http://codereview.chromium.org/173260/diff/1/5#newcode17 Line 17: double Y; // luminance Our ...
11 years, 4 months ago (2009-08-24 01:05:50 UTC) #2
tfarina (gmail-do not use)
On 2009/08/24 01:05:50, Mark Mentovai wrote: > Quick drive-by nit. > > http://codereview.chromium.org/173260/diff/1/5 > File ...
11 years, 4 months ago (2009-08-24 01:15:23 UTC) #3
tfarina (gmail-do not use)
http://codereview.chromium.org/173260/diff/1/5 File app/gfx/color_utils.h (right): http://codereview.chromium.org/173260/diff/1/5#newcode17 Line 17: double Y; // luminance On 2009/08/24 01:05:50, Mark ...
11 years, 4 months ago (2009-08-24 01:15:35 UTC) #4
tfarina (gmail-do not use)
Ping
11 years, 4 months ago (2009-08-25 18:44:13 UTC) #5
Mohamed Mansour
LGTM
11 years, 4 months ago (2009-08-26 02:30:16 UTC) #6
tfarina (gmail-do not use)
11 years, 3 months ago (2009-08-27 19:00:12 UTC) #7
On 2009/08/26 02:30:16, Mohamed Mansour wrote:
> LGTM
Thanks Mohamed, can you land it to me?

Powered by Google App Engine
This is Rietveld 408576698