Issue 173233: Use U_ICU_VERSION_SHORT instead of hard-coding the icu data dll and module na...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173233: Use U_ICU_VERSION_SHORT instead of hard-coding the icu data dll and module na... (Closed)

Created:
11 years, 4 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Use U_ICU_VERSION_SHORT instead of hard-coding the icu data dll and module name. This is a companion to http://codereview.chromium.org/174265 BUG=8198 TEST=All the targets relying on ICU are built and run without a problem. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24072

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	base/icu_util.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

jungshik at Google

Hi Brett, This is similar to googleurl change. If you can review it quickly, that ...

11 years, 4 months ago (2009-08-21 22:48:48 UTC) #1

LGTM