Issue 174265: Use U_ICU_VERSION_SHORT macro instead of hard-coding icu data dll and module ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174265: Use U_ICU_VERSION_SHORT macro instead of hard-coding icu data dll and module ... (Closed)

Created:
11 years, 4 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
http://google-url.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Use U_ICU_VERSION_SHORT macro instead of hard-coding icu data dll and module name. BUG=8198 TEST=googleurl test should be built and run without a problem. Committed: in GoogleURL (r114) by Brett and pulled in to Chrome trunk (r24584)

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/gurl_test_main.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

Hi Brett, Can you review this and land it in googleurl? Once it's landed in ...

11 years, 4 months ago (2009-08-21 22:43:33 UTC) #1

brettw

LGTM. I checked this in as googleurl@114, but did not pull it into Chrome via ...

11 years, 4 months ago (2009-08-22 01:01:50 UTC) #2

jungshik at Google

11 years, 4 months ago (2009-08-22 01:10:44 UTC) #3

On 2009/08/22 01:01:50, brettw wrote:
> LGTM. I checked this in as googleurl@114, but did not pull it into Chrome via
> deps.

Thanks a lot. I'll pull googleurl@114 in as a part of my ICU upgrade DEPS switch
:-)

Expand Messages | Collapse Messages