Issue 173204: Disable flaky ShowModalDialogTest.BasicTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173204: Disable flaky ShowModalDialogTest.BasicTest (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Disable flaky ShowModalDialogTest.BasicTest TBR=jam http://crbug.com/17806 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23974

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/browser_uitest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Sorry, it's #4 flaky test now and going up very quickly. In case you want ...

11 years, 4 months ago (2009-08-21 17:52:42 UTC) #1

jam

11 years, 4 months ago (2009-08-21 18:35:20 UTC) #2

On 2009/08/21 17:52:42, Paweł Hajdan Jr. wrote:
> Sorry, it's #4 flaky test now and going up very quickly.
> 
> In case you want to see: http://build.chromium.org/buildbot/flakiness-report/
> 
> I'm working on a real fix. But in case I don't have it for a while: please
don't
> re-enable the test without a real fix, as said in the comment.

lgtm, as long as you're working on the test (just assigned you the bug)

Expand Messages | Collapse Messages