Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/browser/browser_uitest.cc

Issue 173204: Disable flaky ShowModalDialogTest.BasicTest (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_uitest.cc
diff --git a/chrome/browser/browser_uitest.cc b/chrome/browser/browser_uitest.cc
index 231eb75ea8d238731814b772519821a6148efb03..7c99b3a1de263e75c8f484fecc6d03814b2e6943 100644
--- a/chrome/browser/browser_uitest.cc
+++ b/chrome/browser/browser_uitest.cc
@@ -212,7 +212,9 @@ class ShowModalDialogTest : public UITest {
}
};
-TEST_F(ShowModalDialogTest, BasicTest) {
+// So flaky, http://crbug.com/17806. Do *not* re-enable without a real fix.
+// Increasing timeouts is not a fix.
+TEST_F(ShowModalDialogTest, DISABLED_BasicTest) {
// Test that a modal dialog is shown.
FilePath test_file(test_data_directory_);
test_file = test_file.AppendASCII("showmodaldialog.html");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698