Issue 173194: [Mac] Omnibox keyword, keyword hint, and search hint support....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173194: [Mac] Omnibox keyword, keyword hint, and search hint support.... (Closed)

Created:
11 years, 4 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Omnibox keyword, keyword hint, and search hint support. BUG=http://crbug.com/10944 BUG=http://crbug.com/10943 BUG=http://crbug.com/12285 TEST=With empty field, should see "Type to search" in light text on the RHS of the omnibox. Type "google" and should see "Press [Tab] to search Google" in light text on the RHS. Hit TAB, should see a rounded [Search Google:] item on the left and the cursor is now right of that. Popup should show "Keyword:" in some entries. Patch by shess@chromium.org. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23964

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1060 lines, -23 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	7 chunks	+29 lines, -0 lines	0 comments	Download
MM	chrome/browser/cocoa/autocomplete_text_field.h	View	2 chunks	+27 lines, -4 lines	0 comments	Download
MM	chrome/browser/cocoa/autocomplete_text_field.mm	View	1 chunk	+67 lines, -0 lines	0 comments	Download
MM	chrome/browser/cocoa/autocomplete_text_field_cell.h	View	1 chunk	+60 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_cell.mm	View	4 chunks	+230 lines, -9 lines	0 comments	Download
MM	chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm	View	2 chunks	+210 lines, -7 lines	0 comments	Download
MM	chrome/browser/cocoa/autocomplete_text_field_editor.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
MM	chrome/browser/cocoa/autocomplete_text_field_unittest.mm	View	8 chunks	+212 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.h	View	4 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.mm	View	4 chunks	+113 lines, -1 line	0 comments	Download
MM	chrome/browser/cocoa/location_bar_view_mac_unittest.mm	View	2 chunks	+77 lines, -0 lines	0 comments	Download