[Mac] Omnibox keyword, keyword hint, and search hint support....

chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 #include "app/gfx/font.h"
 #include "app/resource_bundle.h"
 #include "base/clipboard.h"
@@ skipping 274 matching lines @@
 void AutocompleteEditViewMac::SetUserText(const std::wstring& text,
                                           const std::wstring& display_text,
                                           bool update_popup) {
   model_->SetUserText(text);
   // TODO(shess): TODO below from gtk.
   // TODO(deanm): something about selection / focus change here.
   SetText(display_text);
   if (update_popup) {
     UpdatePopup();
   }
+  controller_->OnChanged();
 }
 
 NSRange AutocompleteEditViewMac::GetSelectedRange() const {
   DCHECK([field_ currentEditor]);
   return [[field_ currentEditor] selectedRange];
 }
 
 void AutocompleteEditViewMac::SetSelectedRange(const NSRange range) {
   // This can be called when we don't have focus.  For instance, when
   // the user clicks the "Go" button.
@@ skipping 115 matching lines @@
     if (scheme_security_level == ToolbarModel::SECURE) {
       color = SecureSchemeColor();
     } else {
       color = InsecureSchemeColor();
     }
     [as addAttribute:NSForegroundColorAttributeName value:color
                range:ComponentToNSRange(parts.scheme)];
   }
 
   [field_ setObjectValue:as];
+
+  // TODO(shess): This may be an appropriate place to call:
+  //   controller_->OnChanged();
+  // In the current implementation, this tells LocationBarViewMac to
+  // mess around with |model_| and update |field_|.  Unfortunately,
+  // when I look at our peer implementations, it's not entirely clear
+  // to me if this is safe.  SetText() is sort of an utility method,
+  // and different callers sometimes have different needs.  Research
+  // this issue so that it can be added safely.
+
+  // TODO(shess): Also, consider whether this code couldn't just
+  // manage things directly.  Windows uses a series of overlaid view
+  // objects to accomplish the hinting stuff that OnChanged() does, so
+  // it makes sense to have it in the controller that lays those
+  // things out.  Mac instead pushes the support into a custom
+  // text-field implementation.
 }
 
 void AutocompleteEditViewMac::SetTextAndSelectedRange(
     const std::wstring& display_text, const NSRange range) {
   SetText(display_text);
   SetSelectedRange(range);
 }
 
 void AutocompleteEditViewMac::EmphasizeURLComponents() {
   if ([field_ currentEditor]) {
     SetTextAndSelectedRange(GetText(), GetSelectedRange());
   } else {
     SetText(GetText());
   }
 }
 
 void AutocompleteEditViewMac::OnTemporaryTextMaybeChanged(
     const std::wstring& display_text, bool save_original_selection) {
   // TODO(shess): I believe this is for when the user arrows around
   // the popup, will be restored if they hit escape.  Figure out if
   // that is for certain it.
   if (save_original_selection) {
     saved_temporary_selection_ = GetSelectedRange();
     saved_temporary_text_ = GetText();
   }
 
   SetWindowTextAndCaretPos(display_text, display_text.size());
+  controller_->OnChanged();
 }
 
 bool AutocompleteEditViewMac::OnInlineAutocompleteTextMaybeChanged(
     const std::wstring& display_text, size_t user_text_length) {
   // TODO(shess): Make sure that this actually works.  The round trip
   // to native form and back may mean that it's the same but not the
   // same.
   if (display_text == GetText()) {
     return false;
   }
 
   DCHECK_LE(user_text_length, display_text.size());
   const NSRange range = NSMakeRange(user_text_length, display_text.size());
   SetTextAndSelectedRange(display_text, range);
+  controller_->OnChanged();
 
   return true;
 }
 
 void AutocompleteEditViewMac::OnRevertTemporaryText() {
   SetTextAndSelectedRange(saved_temporary_text_, saved_temporary_selection_);
   saved_temporary_text_.clear();
 }
 
 bool AutocompleteEditViewMac::IsFirstResponder() const {
@@ skipping 37 matching lines @@
 
   const bool something_changed = model_->OnAfterPossibleChange(new_text,
       selection_differs, text_differs, just_deleted_text, at_end_of_edit);
 
   // Restyle in case the user changed something.
   // TODO(shess): I believe there are multiple-redraw cases, here.
   // Linux watches for something_changed && text_differs, but that
   // fails for us in case you copy the URL and paste the identical URL
   // back (we'll lose the styling).
   EmphasizeURLComponents();
+  controller_->OnChanged();
 
   return something_changed;
 }
 
 gfx::NativeView AutocompleteEditViewMac::GetNativeView() const {
   return field_;
 }
 
 void AutocompleteEditViewMac::OnUpOrDownKeyPressed(bool up, bool by_page) {
   // We should only arrive here when the field is focussed.
@@ skipping 69 matching lines @@
 
 void AutocompleteEditViewMac::OnControlKeyChanged(bool pressed) {
   model_->OnControlKeyChanged(pressed);
 }
 
 void AutocompleteEditViewMac::AcceptInput(
     WindowOpenDisposition disposition, bool for_drop) {
   model_->AcceptInput(disposition, for_drop);
 }
 
+void AutocompleteEditViewMac::AcceptKeyword() {
+  model_->AcceptKeyword();
+}
+
 void AutocompleteEditViewMac::FocusLocation() {
   [[field_ window] makeFirstResponder:field_];
   DCHECK_EQ([field_ currentEditor], [[field_ window] firstResponder]);
 }
 
 // TODO(shess): Copied from autocomplete_edit_view_win.cc.  Could this
 // be pushed into the model?
 std::wstring AutocompleteEditViewMac::GetClipboardText(Clipboard* clipboard) {
   // autocomplete_edit_view_win.cc assumes this can never happen, we
   // will too.
@@ skipping 65 matching lines @@
   if (cmd == @selector(scrollPageUp:)) {
     edit_view_->OnUpOrDownKeyPressed(true, true);
     return YES;
   }
 
   if (cmd == @selector(cancelOperation:)) {
     edit_view_->OnEscapeKeyPressed();
     return YES;
   }
 
+  if (cmd == @selector(insertTab:)) {
+    edit_view_->AcceptKeyword();
+    return YES;
+  }
+
   // |-noop:| is sent when the user presses Cmd+Return. Override the no-op
   // behavior with the proper WindowOpenDisposition.
   NSEvent* event = [NSApp currentEvent];
   if (cmd == @selector(insertNewline:) ||
      (cmd == @selector(noop:) && [event keyCode] == kVK_Return)) {
     WindowOpenDisposition disposition =
         event_utils::WindowOpenDispositionFromNSEvent(event);
     edit_view_->AcceptInput(disposition, false);
     return YES;
   }
@@ skipping 59 matching lines @@
 // prepended and ".com" appended.  This calls down to
 // AutocompleteEditModel::OnControlKeyChanged() so that it can change
 // the popup to reflect this.  See autocomplete_edit.cc
 // OnControlKeyChanged() and OnAfterPossibleChange().
 - (void)control:(NSControl*)control flagsChanged:(NSEvent*)theEvent {
   BOOL controlFlag = ([theEvent modifierFlags]&NSControlKeyMask) != 0;
   edit_view_->OnControlKeyChanged(controlFlag);
 }
 
 @end