Issue 173115: Change some integer types to make the x64 Win32 platform happier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173115: Change some integer types to make the x64 Win32 platform happier. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change some integer types to make the x64 Win32 platform happier. Committed: http://code.google.com/p/v8/source/detail?r=2743

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -21 lines)			Patch
M	src/objects.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 2	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/platform-win32.cc	View	1 2	3 chunks	+12 lines, -6 lines	0 comments	Download
M	src/utils.h	View	1 2	2 chunks	+7 lines, -5 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 4 months ago (2009-08-20 11:33:51 UTC) #2

LGTM

http://codereview.chromium.org/173115/diff/1/7
File src/objects-inl.h (right):

http://codereview.chromium.org/173115/diff/1/7#newcode940
Line 940: int map_page_index = static_cast<int>(
How about putting all on the next line - I think that should fit?

int map_page_index =
    static_cast<int>((value_ & kMapPageIndexMask) >> kMapPageIndexShift);

http://codereview.chromium.org/173115/diff/1/6
File src/x64/codegen-x64.h (right):

http://codereview.chromium.org/173115/diff/1/6#newcode35
Line 35: const int32_t kSmiTagMask32 = 0x00000001;
Maybe we can have kSmiTagMask always be a 32-bit type instead of adding another
constant?

Expand Messages | Collapse Messages