src/x64/codegen-x64.cc - Issue 173115: Change some integer types to make the x64 Win32 platform happier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 173115: Change some integer types to make the x64 Win32 platform happier. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.cc

===================================================================

--- src/x64/codegen-x64.cc (revision 2742)

+++ src/x64/codegen-x64.cc (working copy)

@@ -6264,8 +6264,8 @@

} else {

unsigned_left >>= shift_amount;

}

- ASSERT(Smi::IsValid(unsigned_left)); // Converted to signed.

- answer_object = Smi::FromInt(unsigned_left); // Converted to signed.

+ ASSERT(Smi::IsValid(static_cast<int32_t>(unsigned_left)));

+ answer_object = Smi::FromInt(static_cast<int32_t>(unsigned_left));

break;

}

default:

« no previous file with comments | « src/utils.h ('k') | no next file » | no next file with comments »