Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 173044: This changelist represents the necessary merger of two others:... (Closed)

Created:
11 years, 4 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

This changelist represents the necessary merger of two others: http://codereview.chromium.org/172082 Create new event_utils.h file for Cocoa-specific event to WindowOpenDisposition cracking. Hook this up to BookmarkBarController so that clicks to bookmark items use the oracle function to determine where the bookmark should be opened. BUG=17301 TEST=Cmd+Click etc on bookmark items should work. See bug and unit test attached. http://codereview.chromium.org/174021 Convert users of the "get last active browser, get selected tab contents, open url" pattern to just call OpenURL on Browser directly. Makes GetOrCreateTabbedBrowser public on Browser, and makes it static so it can be called with a provided profile. BUG=none TEST=Try opening links from the bookmark/history menus on mac, with and without an existing window open, with an active incognito window, etc. The links should all open in the last active non-incognito window, or create a new non-incognito window if none is open. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -145 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/browser.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/browser.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 5 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller_unittest.mm View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm View 2 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 1 chunk +1 line, -4 lines 0 comments Download
A chrome/browser/cocoa/event_utils.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/event_utils.mm View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/event_utils_unittest.mm View 1 chunk +62 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/history_menu_cocoa_controller.mm View 2 chunks +6 lines, -16 lines 0 comments Download
M chrome/browser/cocoa/infobar_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/browser/cocoa/test_event_utils.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/test_event_utils.mm View 1 chunk +45 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 5 chunks +5 lines, -3 lines 0 comments Download
D chrome/common/cocoa_utils.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/common/cocoa_utils.mm View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/common/cocoa_utils_unittest.mm View 1 chunk +0 lines, -23 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698