Issue 1730014: Revert r45652 and r45653. It broke the single file export...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1730014: Revert r45652 and r45653. It broke the single file export... (Closed)

Created:
10 years, 8 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
jamesr, piman

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Revert r45652 and r45653. It broke the single file export feature. TBR=piman,jamesr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45660

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -326 lines)			Patch
M	gclient.py	View	4 chunks	+73 lines, -129 lines	0 comments	Download
M	gclient_utils.py	View	2 chunks	+0 lines, -106 lines	0 comments	Download
M	tests/gclient_test.py	View	28 chunks	+28 lines, -91 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

Here's an example of the build break: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/6459/steps/gclient/logs/stdio Looks like it's resolving the URL wrong ...

10 years, 8 months ago (2010-04-27 01:56:20 UTC) #2

piman

10 years, 8 months ago (2010-04-27 02:21:56 UTC) #3

On Mon, Apr 26, 2010 at 6:56 PM, <tony@chromium.org> wrote:

> Here's an example of the build break:
>
>
http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/6459/steps/g...
>
> Looks like it's resolving the URL wrong in the case of File().

Sorry about that... I guess I'm really not familiar with the Webkit bots and
what they are doing different.

Antoine

>
>
> http://codereview.chromium.org/1730014/show
>

Expand Messages | Collapse Messages