Revert r45652 and r45653. It broke the single file export...

tests/gclient_test.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for gclient.py."""
 
 # Fixes include path.
 from super_mox import mox, SuperMoxTestBase
 
@@ skipping 37 matching lines @@
     gclient.GClient = self._gclient_gclient
     gclient.gclient_scm.CreateSCM = self._scm_wrapper
     BaseTestCase.tearDown(self)
 
 
 class GclientTestCase(GClientBaseTestCase):
   class OptionsObject(object):
     def __init__(self, test_case, verbose=False, spec=None,
                  config_filename='a_file_name',
                  entries_filename='a_entry_file_name',
-                 deps_file='a_deps_file_name', force=False, nohooks=False,
-                 jobs=1):
+                 deps_file='a_deps_file_name', force=False, nohooks=False):
       self.verbose = verbose
       self.spec = spec
       self.name = None
       self.config_filename = config_filename
       self.entries_filename = entries_filename
       self.deps_file = deps_file
       self.force = force
       self.nohooks = nohooks
-      self.jobs = jobs
-      self.revision = None
       self.revisions = []
       self.manually_grab_svn_rev = True
       self.deps_os = None
       self.head = False
 
       # Mox
       self.platform = test_case.platform
 
   def setUp(self):
     GClientBaseTestCase.setUp(self)
@@ skipping 212 matching lines @@
 
 class TestDoRevert(GenericCommandTestCase):
   def testBasic(self):
     self.ReturnValue('revert', gclient.DoRevert, 0)
   def testError(self):
     self.ReturnValue('revert', gclient.DoRevert, 42)
   def testBadClient(self):
     self.BadClient(gclient.DoRevert)
 
 
-def CompareOptions(options):
-  def _Compare(other):
-    options_keys = [i for i in dir(options) if not i.startswith('_')]
-    other_keys = [i for i in dir(other) if not i.startswith('_')]
-    if set(options_keys) != set(other_keys):
-      return False
-    try:
-      for key in options_keys:
-        if getattr(options, key) != getattr(other, key):
-          return False
-      return True
-    except AttributeError:
-      return False
-  return _Compare
-
 class GClientClassTestCase(GclientTestCase):
   def testDir(self):
     members = [
       'ConfigContent', 'FileImpl', 'FromImpl', 'GetVar', 'LoadCurrentConfig',
       'RunOnDeps', 'SaveConfig', 'SetConfig', 'SetDefaultConfig',
-      'supported_commands', 'PrintRevInfo', 'GetSCMCommandClosure',
+      'supported_commands', 'PrintRevInfo',
     ]
 
     # If you add a member, be sure to add the relevant test!
     self.compareMembers(self._gclient_gclient('root_dir', 'options'), members)
 
   def testSetConfig_ConfigContent_GetVar_SaveConfig_SetDefaultConfig(self):
     options = self.Options()
     text = "# Dummy content\nclient = 'my client'"
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.config_filename),
@@ skipping 62 matching lines @@
     # Expect a check for the entries file and we say there is not one.
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
 
     # An scm will be requested for the solution.
     scm_wrapper_sol = self.mox.CreateMockAnything()
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, solution_name
         ).AndReturn(scm_wrapper_sol)
     # Then an update will be performed.
-    scm_wrapper_sol.RunCommand('update', mox.Func(CompareOptions(options)),
-                               self.args, [])
+    scm_wrapper_sol.RunCommand('update', options, self.args, [])
     # Then an attempt will be made to read its DEPS file.
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, solution_name, options.deps_file)
         ).AndRaise(IOError(2, 'No DEPS file'))
 
     # After everything is done, an attempt is made to write an entries
     # file.
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         entries_content)
@@ skipping 39 matching lines @@
         ).AndReturn(False)
     # Expect a check for the entries file and we say there is not one.
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
 
     # An scm will be requested for the solution.
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, solution_name
         ).AndReturn(scm_wrapper_sol)
     # Then an update will be performed.
-    scm_wrapper_sol.RunCommand('update', mox.Func(CompareOptions(options)),
-                               self.args, [])
+    scm_wrapper_sol.RunCommand('update', options, self.args, [])
     # Then an attempt will be made to read its DEPS file.
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, solution_name, options.deps_file)
         ).AndReturn(deps)
 
     # Next we expect an scm to be request for dep src/t but it should
     # use the url specified in deps and the relative path should now
     # be relative to the DEPS file.
     gclient.gclient_scm.CreateSCM(
         'svn://scm.t/trunk',
         self.root_dir,
         gclient.os.path.join(solution_name, "src", "t")
         ).AndReturn(scm_wrapper_t)
-    scm_wrapper_t.RunCommand('update', mox.Func(CompareOptions(options)),
-                             self.args, [])
+    scm_wrapper_t.RunCommand('update', options, self.args, [])
 
     # After everything is done, an attempt is made to write an entries
     # file.
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         entries_content)
 
     self.mox.ReplayAll()
     client = self._gclient_gclient(self.root_dir, options)
     client.SetConfig(gclient_config)
@@ skipping 42 matching lines @@
 
     # Expect a check for the entries file and we say there is not one.
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
 
     # An scm will be requested for the solution.
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, solution_name
         ).AndReturn(scm_wrapper_sol)
     # Then an update will be performed.
-    scm_wrapper_sol.RunCommand('update', mox.Func(CompareOptions(options)),
-                               self.args, [])
+    scm_wrapper_sol.RunCommand('update', options, self.args, [])
     # Then an attempt will be made to read its DEPS file.
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(checkout_path, options.deps_file)
         ).AndReturn(deps)
 
     # Next we expect an scm to be request for dep src/n even though it does not
     # exist in the DEPS file.
     gclient.gclient_scm.CreateSCM('svn://custom.n/trunk',
                                   self.root_dir,
                                   "src/n").AndReturn(scm_wrapper_n)
 
     # Next we expect an scm to be request for dep src/t but it should
     # use the url specified in custom_deps.
     gclient.gclient_scm.CreateSCM('svn://custom.t/trunk',
                                   self.root_dir,
                                   "src/t").AndReturn(scm_wrapper_t)
 
-    scm_wrapper_n.RunCommand('update', mox.Func(CompareOptions(options)),
-                             self.args, [])
-    scm_wrapper_t.RunCommand('update', mox.Func(CompareOptions(options)),
-                             self.args, [])
+    scm_wrapper_n.RunCommand('update', options, self.args, [])
+    scm_wrapper_t.RunCommand('update', options, self.args, [])
 
     # NOTE: the dep src/b should not create an scm at all.
 
     # After everything is done, an attempt is made to write an entries
     # file.
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         entries_content)
 
     self.mox.ReplayAll()
@@ skipping 54 matching lines @@
         ).AndReturn(False)
 
     # An scm will be requested for the first solution.
     gclient.gclient_scm.CreateSCM(url_a, self.root_dir, name_a).AndReturn(
         scm_wrapper_a)
     # Then an attempt will be made to read it's DEPS file.
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name_a, options.deps_file)
         ).AndReturn(deps_a)
     # Then an update will be performed.
-    scm_wrapper_a.RunCommand('update', mox.Func(CompareOptions(options)),
-                             self.args, [])
+    scm_wrapper_a.RunCommand('update', options, self.args, [])
 
     # An scm will be requested for the second solution.
     gclient.gclient_scm.CreateSCM(url_b, self.root_dir, name_b).AndReturn(
         scm_wrapper_b)
     # Then an attempt will be made to read its DEPS file.
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name_b, options.deps_file)
         ).AndReturn(deps_b)
     # Then an update will be performed.
-    scm_wrapper_b.RunCommand('update', mox.Func(CompareOptions(options)),
-                             self.args, [])
+    scm_wrapper_b.RunCommand('update', options, self.args, [])
 
     # Finally, an scm is requested for the shared dep.
     gclient.gclient_scm.CreateSCM('http://svn.t/trunk', self.root_dir, 'src/t'
         ).AndReturn(scm_wrapper_dep)
     # And an update is run on it.
-    scm_wrapper_dep.RunCommand('update', mox.Func(CompareOptions(options)),
-                               self.args, [])
+    scm_wrapper_dep.RunCommand('update', options, self.args, [])
 
     # After everything is done, an attempt is made to write an entries file.
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         entries_content)
 
     self.mox.ReplayAll()
     client = self._gclient_gclient(self.root_dir, options)
     client.SetConfig(gclient_config)
     client.RunOnDeps('update', self.args)
@@ skipping 14 matching lines @@
     ) % (name, self.url)
 
     options = self.Options()
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, name, '.git')
         ).AndReturn(False)
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name, options.deps_file)
         ).AndReturn("Boo = 'a'")
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         entries_content)
 
     self.mox.ReplayAll()
     client = self._gclient_gclient(self.root_dir, options)
     client.SetConfig(gclient_config)
@@ skipping 199 matching lines @@
         gclient.os.path.join(self.root_dir, 'foo/third_party/WebKit', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, name, '.git')
         ).AndReturn(False)
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, None
                                   ).AndReturn(scm_wrapper_src)
     scm_wrapper_src.FullUrlForRelativeUrl('/trunk/bar/WebKit'
         ).AndReturn(webkit_path)
 
     gclient.gclient_scm.CreateSCM(
         webkit_path, self.root_dir, 'foo/third_party/WebKit'
         ).AndReturn(gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     self.mox.ReplayAll()
     client = self._gclient_gclient(self.root_dir, options)
     client.SetConfig(gclient_config)
     client.RunOnDeps('update', self.args)
 
   def testRunOnDepsSuccessCustomVars(self):
     # Fake .gclient file.
     name = 'testRunOnDepsSuccessCustomVars_solution_name'
     gclient_config = """solutions = [ {
@@ skipping 33 matching lines @@
         gclient.os.path.join(self.root_dir, 'foo/third_party/WebKit', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, name, '.git')
         ).AndReturn(False)
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir,
                        None).AndReturn(scm_wrapper_src)
     scm_wrapper_src.FullUrlForRelativeUrl('/trunk/bar_custom/WebKit'
         ).AndReturn(webkit_path)
 
     gclient.gclient_scm.CreateSCM(webkit_path, self.root_dir,
         'foo/third_party/WebKit').AndReturn(gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     self.mox.ReplayAll()
     client = self._gclient_gclient(self.root_dir, options)
     client.SetConfig(gclient_config)
     client.RunOnDeps('update', self.args)
 
   def testRunOnDepsFailureVars(self):
     # Fake .gclient file.
     name = 'testRunOnDepsFailureVars_solution_name'
     gclient_config = """solutions = [ {
   'name': '%s',
   'url': '%s',
   'custom_deps': {},
   'custom_vars': {},
 }, ]""" % (name, self.url)
     # Fake DEPS file.
     deps_content = """deps = {
   'foo/third_party/WebKit': Var('webkit') + 'WebKit',
 }"""
 
     options = self.Options()
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name, options.deps_file)
         ).AndReturn(deps_content)
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     self.mox.ReplayAll()
     client = self._gclient_gclient(self.root_dir, options)
     client.SetConfig(gclient_config)
     exception = "Var is not defined: webkit"
     try:
       client.RunOnDeps('update', self.args)
     except gclient.gclient_utils.Error, e:
       self.assertEquals(e.args[0], exception)
     else:
@@ skipping 42 matching lines @@
 
     options = self.Options()
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, 'main', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, 'base', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, name, '.git')
         ).AndReturn(False)
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name, options.deps_file)
         ).AndReturn(deps_content)
     
     # base gets updated.
     gclient.gclient_scm.CreateSCM(base_url, self.root_dir, 'base').AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, 'base', options.deps_file)
         ).AndReturn(base_deps_content)
 
     # main gets updated.
     gclient.gclient_scm.CreateSCM(main_url, self.root_dir, 'main').AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     # Process is done and will write an .gclient_entries.    
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         mox.IgnoreArg())
 
     self.mox.ReplayAll()
@@ skipping 26 matching lines @@
 
     options = self.Options()
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, 'main', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, 'base', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, name, '.git')
         ).AndReturn(False)
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name, options.deps_file)
         ).AndReturn(deps_content)
     
     # base gets updated.
     gclient.gclient_scm.CreateSCM(base_url, self.root_dir, 'base').AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, 'base', options.deps_file)
         ).AndReturn(base_deps_content)
 
     # main gets updated.
     gclient.gclient_scm.CreateSCM(main_url, self.root_dir, 'main').AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     # Process is done and will write an .gclient_entries.    
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         mox.IgnoreArg())
 
     self.mox.ReplayAll()
@@ skipping 26 matching lines @@
 
     options = self.Options()
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, 'main', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, 'base', '.git')
         ).AndReturn(False)
     gclient.os.path.exists(gclient.os.path.join(self.root_dir, name, '.git')
         ).AndReturn(False)
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name, options.deps_file)
         ).AndReturn(deps_content)
     
     # base gets updated.
     gclient.gclient_scm.CreateSCM(base_url, self.root_dir, 'base').AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, 'base', options.deps_file)
         ).AndReturn(base_deps_content)
 
     # main gets updated after resolving the relative url.
     gclient.gclient_scm.CreateSCM(base_url, self.root_dir, None).AndReturn(
         gclient.gclient_scm.CreateSCM)
     gclient.gclient_scm.CreateSCM.FullUrlForRelativeUrl(main_url
         ).AndReturn('svn://base' + main_url)
     gclient.gclient_scm.CreateSCM('svn://base' + main_url, self.root_dir,
         'main').AndReturn(gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
 
     # Process is done and will write an .gclient_entries.    
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         mox.IgnoreArg())
 
     self.mox.ReplayAll()
@@ skipping 11 matching lines @@
     # Fake DEPS file.
     target = "chromium_deps"
     deps_content = (
         "deps = {"
         "  '%s': File('%s/DEPS') }" % (target, self.url)
     )
 
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
         gclient.gclient_scm.CreateSCM)
     options = self.Options()
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        'update', mox.Func(CompareOptions(options)), self.args, [])
+    gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
     gclient.gclient_utils.FileRead(
         gclient.os.path.join(self.root_dir, name, options.deps_file)
         ).AndReturn(deps_content)
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, name, '.git')
         ).AndReturn(False)
     gclient.os.path.exists(
         gclient.os.path.join(self.root_dir, options.entries_filename)
         ).AndReturn(False)
 
     # This is where gclient tries to do the initial checkout.
     gclient.gclient_scm.CreateSCM(self.url, self.root_dir, target).AndReturn(
         gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand('updatesingle',
-                                             mox.Func(CompareOptions(options)),
+    gclient.gclient_scm.CreateSCM.RunCommand('updatesingle', options,
         self.args + ["DEPS"], [])
     gclient.gclient_utils.FileWrite(
         gclient.os.path.join(self.root_dir, options.entries_filename),
         "entries = \\\n{ '%s': '%s'}\n" % (name, self.url))
 
     self.mox.ReplayAll()
     client = self._gclient_gclient(self.root_dir, options)
     client.SetConfig(gclient_config)
     client.RunOnDeps('update', self.args)
 
   def test_PrintRevInfo(self):
     # TODO(aharper): no test yet for revinfo, lock it down once we've verified
     # implementation for Pulse plugin
     pass
 
-  def testGetSCMCommandClosure(self):
-    options = self.Options()
-    name = 'testGetSCMCommandClosure_name'
-    command = 'testGetSCMCommandClosure_command'
-    revision = '123'
-    file_list = []
-    called_options = self.Options()
-    called_options.revision = revision
-    gclient.gclient_scm.CreateSCM(self.url, self.root_dir, name).AndReturn(
-        gclient.gclient_scm.CreateSCM)
-    gclient.gclient_scm.CreateSCM.RunCommand(
-        command, mox.Func(CompareOptions(called_options)), self.args, file_list)
-
-    self.mox.ReplayAll()
-    client = self._gclient_gclient(self.root_dir, options)
-    closure = client.GetSCMCommandClosure(name, self.url, revision, command,
-                                          self.args, file_list)
-    closure()
-
   # No test for internal functions.
   def test_GetAllDeps(self):
     pass
   def test_GetDefaultSolutionDeps(self):
     pass
   def test_LoadConfig(self):
     pass
   def test_ReadEntries(self):
     pass
   def test_SaveEntries(self):
     pass
   def test_VarImpl(self):
     pass
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()
 
 # vim: ts=2:sw=2:tw=80:et: