fullscreen window app launch container

fullscreen window app launch container

BUG=42447
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45862

[Erik does not do reviews, 2010-04-26 00:24:32]

I'm not sure if this makes sense as a separate launch container, or whether it
should be another variable.  It felt a little strange for a tab or a panel to
have a full screen setting though.  The other option I was thinking was that we
could make this entirely a user setting (similar to our thoughts on window vs.
tab), but given that we haven't talked through that yet, this seemed like the
best approach for now.

[Erik does not do reviews, 2010-04-27 22:11:47]

I changed fullscreen to be a general option for all containers.  PTAL.

[Aaron Boodman, 2010-04-27 22:16:04]

Please add at least some basic tests (like see extension_manifest_unittests) so
that we don't break this. Reviewing now...

[Aaron Boodman, 2010-04-27 22:18:28]

http://codereview.chromium.org/1730013/diff/6001/7001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/1730013/diff/6001/7001#newcode477
chrome/browser/browser.cc:477: if (extension && extension->launch_fullscreen())
Did you try putting this in ::OpenApplication() instead so that it doesn't have
to be duplicated?

[Erik does not do reviews, 2010-04-28 00:08:48]

I did a bit of refactoring and cleanup.  Still no unit test, but take a look and
tell me what you think of the direction.

[Aaron Boodman, 2010-04-28 17:55:18]

lgtm, whenever you're ready.

[Lei Zhang, 2010-04-29 02:25:43]

The new .json files you added got checked in with svn:executable set. Can you
fix your svn/git client?