Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 1730013: fullscreen window app launch container (Closed)
Patch Set: added tests Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/scoped_ptr.h" 8 #include "base/scoped_ptr.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 return extension; 54 return extension;
55 } 55 }
56 56
57 void LoadAndExpectError(const std::string& name, 57 void LoadAndExpectError(const std::string& name,
58 const std::string& expected_error) { 58 const std::string& expected_error) {
59 std::string error; 59 std::string error;
60 scoped_ptr<Extension> extension(LoadExtension(name, &error)); 60 scoped_ptr<Extension> extension(LoadExtension(name, &error));
61 EXPECT_FALSE(extension.get()) << 61 EXPECT_FALSE(extension.get()) <<
62 "Expected failure loading extension '" << name << 62 "Expected failure loading extension '" << name <<
63 "', but didn't get one."; 63 "', but didn't get one.";
64 EXPECT_TRUE(MatchPatternASCII(error, expected_error)); 64 EXPECT_TRUE(MatchPatternASCII(error, expected_error)) << name <<
65 " expected '" << expected_error << "' but got '" << error << "'";
65 } 66 }
66 67
67 bool enable_apps_; 68 bool enable_apps_;
68 }; 69 };
69 70
70 TEST_F(ManifestTest, AppsDisabledByDefault) { 71 TEST_F(ManifestTest, AppsDisabledByDefault) {
71 enable_apps_ = false; 72 enable_apps_ = false;
72 LoadAndExpectError("web_content_disabled.json", errors::kAppsNotEnabled); 73 LoadAndExpectError("web_content_disabled.json", errors::kAppsNotEnabled);
73 LoadAndExpectError("launch_local_path.json", errors::kAppsNotEnabled); 74 LoadAndExpectError("launch_local_path.json", errors::kAppsNotEnabled);
74 } 75 }
75 76
76 TEST_F(ManifestTest, ValidApp) { 77 TEST_F(ManifestTest, ValidApp) {
77 scoped_ptr<Extension> extension(LoadAndExpectSuccess("valid_app.json")); 78 scoped_ptr<Extension> extension(LoadAndExpectSuccess("valid_app.json"));
78 EXPECT_TRUE(extension->web_content_enabled()); 79 EXPECT_TRUE(extension->web_content_enabled());
79 EXPECT_EQ(GURL("http://www.google.com/"), extension->web_extent().origin()); 80 EXPECT_EQ(GURL("http://www.google.com/"), extension->web_extent().origin());
80 EXPECT_EQ(2u, extension->web_extent().paths().size()); 81 EXPECT_EQ(2u, extension->web_extent().paths().size());
81 EXPECT_EQ("mail/", extension->web_extent().paths()[0]); 82 EXPECT_EQ("mail/", extension->web_extent().paths()[0]);
82 EXPECT_EQ("foobar/", extension->web_extent().paths()[1]); 83 EXPECT_EQ("foobar/", extension->web_extent().paths()[1]);
83 EXPECT_EQ(Extension::LAUNCH_WINDOW, extension->launch_container()); 84 EXPECT_EQ(Extension::LAUNCH_WINDOW, extension->launch_container());
85 EXPECT_EQ(false, extension->launch_fullscreen());
84 EXPECT_EQ("mail/", extension->launch_web_url()); 86 EXPECT_EQ("mail/", extension->launch_web_url());
85 } 87 }
86 88
87 TEST_F(ManifestTest, AppWebContentEnabled) { 89 TEST_F(ManifestTest, AppWebContentEnabled) {
88 LoadAndExpectError("web_content_enabled_invalid.json", 90 LoadAndExpectError("web_content_enabled_invalid.json",
89 errors::kInvalidWebContentEnabled); 91 errors::kInvalidWebContentEnabled);
90 LoadAndExpectError("web_content_disabled.json", 92 LoadAndExpectError("web_content_disabled.json",
91 errors::kWebContentMustBeEnabled); 93 errors::kWebContentMustBeEnabled);
92 LoadAndExpectError("web_content_not_enabled.json", 94 LoadAndExpectError("web_content_not_enabled.json",
93 errors::kWebContentMustBeEnabled); 95 errors::kWebContentMustBeEnabled);
(...skipping 29 matching lines...) Expand all
123 125
124 extension.reset(LoadAndExpectSuccess("launch_window.json")); 126 extension.reset(LoadAndExpectSuccess("launch_window.json"));
125 EXPECT_EQ(Extension::LAUNCH_WINDOW, extension->launch_container()); 127 EXPECT_EQ(Extension::LAUNCH_WINDOW, extension->launch_container());
126 128
127 extension.reset(LoadAndExpectSuccess("launch_panel.json")); 129 extension.reset(LoadAndExpectSuccess("launch_panel.json"));
128 EXPECT_EQ(Extension::LAUNCH_PANEL, extension->launch_container()); 130 EXPECT_EQ(Extension::LAUNCH_PANEL, extension->launch_container());
129 131
130 extension.reset(LoadAndExpectSuccess("launch_default.json")); 132 extension.reset(LoadAndExpectSuccess("launch_default.json"));
131 EXPECT_EQ(Extension::LAUNCH_TAB, extension->launch_container()); 133 EXPECT_EQ(Extension::LAUNCH_TAB, extension->launch_container());
132 134
135 extension.reset(LoadAndExpectSuccess("launch_fullscreen.json"));
136 EXPECT_EQ(true, extension->launch_fullscreen());
137
133 LoadAndExpectError("launch_container_invalid_type.json", 138 LoadAndExpectError("launch_container_invalid_type.json",
134 errors::kInvalidLaunchContainer); 139 errors::kInvalidLaunchContainer);
135 LoadAndExpectError("launch_container_invalid_value.json", 140 LoadAndExpectError("launch_container_invalid_value.json",
136 errors::kInvalidLaunchContainer); 141 errors::kInvalidLaunchContainer);
137 LoadAndExpectError("launch_container_without_launch_url.json", 142 LoadAndExpectError("launch_container_without_launch_url.json",
138 errors::kLaunchContainerWithoutURL); 143 errors::kLaunchContainerWithoutURL);
144 LoadAndExpectError("launch_fullscreen_invalid.json",
145 errors::kInvalidLaunchFullscreen);
139 } 146 }
140 147
141 TEST_F(ManifestTest, AppLaunchURL) { 148 TEST_F(ManifestTest, AppLaunchURL) {
142 LoadAndExpectError("launch_path_and_url.json", 149 LoadAndExpectError("launch_path_and_url.json",
143 errors::kLaunchPathAndURLAreExclusive); 150 errors::kLaunchPathAndURLAreExclusive);
144 LoadAndExpectError("launch_path_invalid_type.json", 151 LoadAndExpectError("launch_path_invalid_type.json",
145 errors::kInvalidLaunchLocalPath); 152 errors::kInvalidLaunchLocalPath);
146 LoadAndExpectError("launch_path_invalid_value.json", 153 LoadAndExpectError("launch_path_invalid_value.json",
147 errors::kInvalidLaunchLocalPath); 154 errors::kInvalidLaunchLocalPath);
148 LoadAndExpectError("launch_url_invalid_type.json", 155 LoadAndExpectError("launch_url_invalid_type.json",
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 188
182 TEST_F(ManifestTest, ChromeURLPermissionInvalid) { 189 TEST_F(ManifestTest, ChromeURLPermissionInvalid) {
183 LoadAndExpectError("permission_chrome_url_invalid.json", 190 LoadAndExpectError("permission_chrome_url_invalid.json",
184 errors::kInvalidPermissionScheme); 191 errors::kInvalidPermissionScheme);
185 } 192 }
186 193
187 TEST_F(ManifestTest, ChromeURLContentScriptInvalid) { 194 TEST_F(ManifestTest, ChromeURLContentScriptInvalid) {
188 LoadAndExpectError("content_script_chrome_url_invalid.json", 195 LoadAndExpectError("content_script_chrome_url_invalid.json",
189 errors::kInvalidMatch); 196 errors::kInvalidMatch);
190 } 197 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_constants.cc ('k') | chrome/test/data/extensions/manifest_tests/launch_fullscreen.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698