Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1727012: GTK: Put options dialogs in a different window group. (Closed)

Created:
10 years, 7 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade, mattm
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

GTK: Put options dialogs in a different window group. GTK grabs work on a per window group basis, so when a modal dialog comes up (which performs a grab) and the user then clicks on something in the main browser window that spawns an InfoBubble, the InfoBubble's code that handles hiding the currently grabbed widget will hide the modal dialog and it is lost until restart. Since we need to remove the centering in ContentSettingsWindowGtk for this to work, also change the centering behaviour for FontsLanguagesWindowGtk, which has bothered me for a while. BUG=41815 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/gtk/options/content_settings_window_gtk.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/gtk/options/fonts_languages_window_gtk.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/options_window_gtk.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
10 years, 7 months ago (2010-04-28 21:07:47 UTC) #1
Evan Stade
if options windows are currently in the same window group as the main window, how ...
10 years, 7 months ago (2010-04-28 21:16:38 UTC) #2
Elliot Glaysher
On Wed, Apr 28, 2010 at 2:16 PM, <estade@chromium.org> wrote: > if options windows are ...
10 years, 7 months ago (2010-04-28 21:26:03 UTC) #3
Evan Stade
10 years, 7 months ago (2010-04-28 21:29:24 UTC) #4
ok, lgtm

Powered by Google App Engine
This is Rietveld 408576698