Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3743)

Unified Diff: chrome/browser/gtk/options/fonts_languages_window_gtk.cc

Issue 1727012: GTK: Put options dialogs in a different window group. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/options/fonts_languages_window_gtk.cc
diff --git a/chrome/browser/gtk/options/fonts_languages_window_gtk.cc b/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
index 8e4253e37ce534dae28a354406eaa0b6898c9458..3b3b750b3244d505e8192b3f5c44af080d094eb7 100644
--- a/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
+++ b/chrome/browser/gtk/options/fonts_languages_window_gtk.cc
@@ -26,7 +26,7 @@ class FontsLanguagesWindowGtk {
~FontsLanguagesWindowGtk();
// Shows the tab corresponding to the specified |page|.
- void ShowTabPage(FontsLanguagesPage page);
+ void ShowTabPage(gfx::NativeWindow window, FontsLanguagesPage page);
private:
static void OnWindowDestroy(GtkWidget* widget,
@@ -110,7 +110,11 @@ FontsLanguagesWindowGtk::FontsLanguagesWindowGtk(Profile* profile)
FontsLanguagesWindowGtk::~FontsLanguagesWindowGtk() {
}
-void FontsLanguagesWindowGtk::ShowTabPage(FontsLanguagesPage page) {
+void FontsLanguagesWindowGtk::ShowTabPage(gfx::NativeWindow window,
+ FontsLanguagesPage page) {
+ // Center our dialog over whoever displayed us.
+ gtk_util::CenterOverWindow(GTK_WINDOW(dialog_), window);
+
// Bring options window to front if it already existed and isn't already
// in front.
gtk_window_present(GTK_WINDOW(dialog_));
@@ -142,5 +146,5 @@ void ShowFontsLanguagesWindow(gfx::NativeWindow window,
if (!instance_)
instance_ = new FontsLanguagesWindowGtk(profile);
- instance_->ShowTabPage(page);
+ instance_->ShowTabPage(window, page);
}
« no previous file with comments | « chrome/browser/gtk/options/content_settings_window_gtk.cc ('k') | chrome/browser/gtk/options/options_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698