Issue 172120: Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172120: Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new"" (Closed)

Created:
11 years, 3 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new"" Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed. BUG=17636 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25329

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+237 lines, -97 lines)			Patch
M	chrome/browser/dom_ui/dom_ui_factory.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_factory.cc	View	2 chunks	+60 lines, -79 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	1 chunk	+74 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_dom_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	3 chunks	+20 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
A	chrome/test/data/extensions/uitest/window_open/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/uitest/window_open/newtab.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/uitest/window_open/test.html	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/perf_expectations/perf_expectations.json	View	1 chunk	+1 line, -4 lines	0 comments	Download