Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: chrome/browser/tab_contents/tab_contents_view.cc

Issue 172120: Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new"" (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents_view.cc
diff --git a/chrome/browser/tab_contents/tab_contents_view.cc b/chrome/browser/tab_contents/tab_contents_view.cc
index 78d084a35907bd2e43d847277945bd3e5aecccea..ecdf6975aa6f9b980f81e2dfcec3c1672b9ac3b1 100644
--- a/chrome/browser/tab_contents/tab_contents_view.cc
+++ b/chrome/browser/tab_contents/tab_contents_view.cc
@@ -32,9 +32,10 @@ void TabContentsView::UpdatePreferredWidth(int pref_width) {
void TabContentsView::CreateNewWindow(int route_id,
base::WaitableEvent* modal_dialog_event) {
- delegate_view_helper_.CreateNewWindow(route_id, modal_dialog_event,
- tab_contents_->profile(),
- tab_contents_->GetSiteInstance());
+ delegate_view_helper_.CreateNewWindow(
+ route_id, modal_dialog_event,
+ tab_contents_->profile(), tab_contents_->GetSiteInstance(),
+ DOMUIFactory::GetDOMUIType(tab_contents_->GetURL()));
}
void TabContentsView::CreateNewWidget(int route_id, bool activatable) {
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/test/data/extensions/uitest/window_open/manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698