Move MessageLoop TaskQueues to pointers.

Move MessageLoop TaskQueues to pointers.

We previously called std::swap on two std::queues.  However, the C++ spec
does not define swap specializations for queues, so this does a full temporary
and copy.  Instead add a level of indirection and swap the pointers.

BUG=20204

[Craig, 2009-09-02 13:20:30]

http://codereview.chromium.org/172101/diff/1/2
File base/message_loop.cc (right):

http://codereview.chromium.org/172101/diff/1/2#newcode84
Line 84: incoming_queue_(new TaskQueue),
Do you have to call delete on this in the destructor or did I miss something?

[Dean McNamee, 2009-09-02 15:43:05]

On Wed, Sep 2, 2009 at 3:20 PM, <craig.schlenter@chromium.org> wrote:
>
> http://codereview.chromium.org/172101/diff/1/2
> File base/message_loop.cc (right):
>
> http://codereview.chromium.org/172101/diff/1/2#newcode84
> Line 84: incoming_queue_(new TaskQueue),
> Do you have to call delete on this in the destructor or did I miss
> something?

Sorry, I am not so smart these days.  Updated to scoped_ptrs.  Thanks

>
> http://codereview.chromium.org/172101

[darin (slow to review), 2009-09-02 16:29:57]

I posted an alternative fix here:
http://codereview.chromium.org/190006

This is something Dean and I discussed this morning just before he logged off.

[Dean McNamee, 2009-09-02 19:56:16]

Your alternative LGTM.

On Wed, Sep 2, 2009 at 6:30 PM, <darin@chromium.org> wrote:
> I posted an alternative fix here:
> http://codereview.chromium.org/190006
>
> This is something Dean and I discussed this morning just before he
> logged off.
>
> http://codereview.chromium.org/172101
>