Update gyp files and DEPS for icu42

Replace icu38/icu38.gyp  with icu/icu.gyp in gyp files replace all the references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc


In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). 

Also updated is the test results for net_util_unittests.


This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). 

BUG=8198
TEST=On all platforms, all the targets are built fine.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25708

[jungshik at Google, 2009-08-16 19:54:08]

Steven, 

This CL has an issue on Mac. 

On Mac, xmllint and xmlcatalog failed to link complaining about undefined
symbols 'operator delete(void*)' and '___cxa_pure_virtual' referenced from
libicuuc.a. xmllint and xmlcatalog are built from C source files and linking is
also done with gcc rather than g++. When I manually linked with g++, they're
linked fine. 

Is there any way to use g++ for linking those two targets in libxml.gyp ? Or,
maybe, we just have to remove them from the target list because I don't see any
use for them in Chrome.

[Mark Mentovai, 2009-08-16 20:51:28]

I recommend adding a dummy .cc file to xmllint and xmlcatalog to convince Xcode
to link them with g++.  This is an Xcode bug.

[jungshik at Google, 2009-08-17 03:38:02]

On 2009/08/16 20:51:28, Mark Mentovai wrote:
> I recommend adding a dummy .cc file to xmllint and xmlcatalog to convince
Xcode
> to link them with g++.  This is an Xcode bug.

Thank you for the help. I updated the CL.

[jungshik at Google, 2009-08-17 17:07:37]

Any opinion about the following alternative to this CL?

1. In the top DEPS file, import 'deps/third_party/icu42' (or any icuNN in the
future) as 'src/third_party/icu'

2. In 'deps/third_party/icuNN', put 'icu.gyp' instead of 'icuNN.gyp'

3. In all other gyp files currently referencing 'icu38/icu38.gyp', replace it
with 'icu/icu.gyp'
 
With that, we can just update DEPS file without updating other gyp files next
time we upgrade ICU. (of course, updating other gyp files is trivial, but ...)

[sgk, 2009-08-17 18:04:14]

patch lgtm

I agree with your suggestion about mapping the version-specific directory to
third_party/icu and taking the version out of the .gyp file specifications.  It
would make it much less error-prone to upgrade.

[Mark Mentovai, 2009-08-17 18:08:31]

LGTM.  I agree with third_party/icu/icu.gyp, etc., as you suggested.

http://codereview.chromium.org/172031/diff/38/44
File third_party/libxml/libxml.gyp (right):

http://codereview.chromium.org/172031/diff/38/44#newcode192
Line 192: 'xmldummy_mac.cc',
This file should have a comment in it saying why we need it.

[jungshik at Google, 2009-08-17 20:50:53]

Thank you for the reviews. 

I've just replaced icu42/icu42.gyp with icu/icu.gyp and maps
deps/third_party/icu42 to src/third_party/icu. 

I also added a comment to xmldummy_mac.cc as Mark suggested. 

Once everything is ready, I'll land this CL with an updated revision for icu42
in DEPS.



On 2009/08/17 18:08:31, Mark Mentovai wrote:
> LGTM.  I agree with third_party/icu/icu.gyp, etc., as you suggested.
> 
> http://codereview.chromium.org/172031/diff/38/44
> File third_party/libxml/libxml.gyp (right):
> 
> http://codereview.chromium.org/172031/diff/38/44#newcode192
> Line 192: 'xmldummy_mac.cc',
> This file should have a comment in it saying why we need it.

[Mark Mentovai, 2009-08-17 20:54:23]

LGTM

[Evan Martin, 2009-09-09 23:06:09]

this broke the scons build

http://paste.ubuntu.com/268250/

[sgk, 2009-09-09 23:33:41]

Patch coming.
The third-party gyp files don't automatically exclude _mac.{cc,mm} files on
non-Mac platforms, like the Chromium .gyp configs do.  So these mac-only
files should be in mac-only conditions.

        --SK

On Wed, Sep 9, 2009 at 4:06 PM, <evan@chromium.org> wrote:

> this broke the scons build
>
> http://paste.ubuntu.com/268250/
>
>
>
> http://codereview.chromium.org/172031
>

[jungshik at Google, 2009-09-10 18:14:32]

On 2009/09/09 23:33:41, sgk wrote:
> Patch coming.
> The third-party gyp files don't automatically exclude _mac.{cc,mm} files on
> non-Mac platforms, like the Chromium .gyp configs do.  So these mac-only
> files should be in mac-only conditions.

Sorry for breaking scons build. I saw them included on linux, but (make) build
ran fine and i thought it's harmless (i meant to ask about it, but forgot).  




> 
>         --SK
> 
> On Wed, Sep 9, 2009 at 4:06 PM, <mailto:evan@chromium.org> wrote:
> 
> > this broke the scons build
> >
> > http://paste.ubuntu.com/268250/
> >
> >
> >
> > http://codereview.chromium.org/172031
> >
>

[sgk, 2009-09-10 18:18:39]

Since it's only a warning, it actually doesn't break our bots, so you
wouldn't have seen red from the trybots anyway.  --SK

On Thu, Sep 10, 2009 at 11:14 AM, <jshin@chromium.org> wrote:

> On 2009/09/09 23:33:41, sgk wrote:
>
>> Patch coming.
>> The third-party gyp files don't automatically exclude _mac.{cc,mm} files
>> on
>> non-Mac platforms, like the Chromium .gyp configs do.  So these mac-only
>> files should be in mac-only conditions.
>>
>
> Sorry for breaking scons build. I saw them included on linux, but (make)
> build
> ran fine and i thought it's harmless (i meant to ask about it, but forgot).
>
>
>
>
>
>          --SK
>>
>
>  On Wed, Sep 9, 2009 at 4:06 PM, <mailto:evan@chromium.org> wrote:
>>
>
>  > this broke the scons build
>> >
>> > http://paste.ubuntu.com/268250/
>> >
>> >
>> >
>> > http://codereview.chromium.org/172031
>> >
>>
>
>
>
>
> http://codereview.chromium.org/172031
>

[tony, 2009-09-10 18:39:08]

I also have a follow up patch to remove these targets (xmllint and xmlcatalog)
from the build.