Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1631030: Adding Chrome preferences for ibus-pinyin. (Closed)

Created:
10 years, 8 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org, mazda, ncarter (slow), idana, tim (not reviewing)
Visibility:
Public.

Description

- Adding Chrome preferences for ibus-pinyin. - Moving all input method related constants from preferences.cc to language_preferences.h. This change is necessary to implement a configuration dialog for Pinyin input method. BUG=crosbug.com/488 TEST=ran browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45292

Patch Set 1 #

Patch Set 2 : for review #

Patch Set 3 : sync prefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -37 lines) Patch
M chrome/browser/chromeos/cros/cros_in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/language_preferences.h View 1 2 chunks +60 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 2 3 chunks +20 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 5 chunks +39 lines, -16 lines 0 comments Download
M chrome/browser/sync/glue/synchronized_preferences.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 chunks +37 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
10 years, 8 months ago (2010-04-21 07:29:57 UTC) #1
satorux1
Shouldn't we update chromeos/browser/sync/synchronized_preferences.h? http://src.chromium.org/viewvc/chrome?view=rev&revision=44993 On 2010/04/21 07:29:57, Yusuke Sato wrote: >
10 years, 8 months ago (2010-04-21 12:32:24 UTC) #2
Zachary Kuznia
You should be able to just add these to the list of synced IME prefs ...
10 years, 8 months ago (2010-04-22 01:08:04 UTC) #3
Yusuke Sato
Thanks, added synchronized_preferences.h to the CL. Please take another look. On 2010/04/22 01:08:04, zork wrote: ...
10 years, 8 months ago (2010-04-22 03:00:27 UTC) #4
satorux1
LGTM from chromium OS
10 years, 8 months ago (2010-04-22 03:44:20 UTC) #5
Zachary Kuznia
10 years, 8 months ago (2010-04-23 09:08:48 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698