Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 17153007: Enable looping of videos in Files.app. (Closed)

Created:
7 years, 6 months ago by mtomasz
Modified:
7 years, 6 months ago
Reviewers:
hashimoto, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Enable looping of videos in Files.app. By clicking the play button or the video while holding CTRL, the video will play in a looped mode. The mode is reset after pausing. TEST=Go to Files.app and play a video. Hit the play button, or the video area with CTRL pressed. A message should be shown and the video should get looped. BUG=249238 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207525

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 2 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/css/media_controls.css View 2 chunks +41 lines, -0 lines 2 comments Download
M chrome/browser/resources/file_manager/js/media/media_controls.js View 8 chunks +77 lines, -17 lines 0 comments Download
M chrome/browser/resources/file_manager/js/media/video_player.js View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/slide_mode.js View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@hashimoto: PTAL at file_browser_private_api.cc. @hirono: PTAL at the rest. This is urgent. Thanks!
7 years, 6 months ago (2013-06-20 08:58:16 UTC) #1
hashimoto
file_browser_private_api.cc lgtm
7 years, 6 months ago (2013-06-20 08:59:34 UTC) #2
hirono
lgtm with nit. Thanks! https://codereview.chromium.org/17153007/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/17153007/diff/1/chrome/app/generated_resources.grd#newcode12635 chrome/app/generated_resources.grd:12635: + This video will keep ...
7 years, 6 months ago (2013-06-20 09:20:46 UTC) #3
mtomasz
https://codereview.chromium.org/17153007/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/17153007/diff/1/chrome/app/generated_resources.grd#newcode12635 chrome/app/generated_resources.grd:12635: + This video will keep playing until the cows ...
7 years, 6 months ago (2013-06-20 09:31:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/17153007/1
7 years, 6 months ago (2013-06-20 09:35:16 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 20:03:29 UTC) #6
Message was sent while issue was closed.
Change committed as 207525

Powered by Google App Engine
This is Rietveld 408576698