Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 171104: Remove one of the GCs performed by the --gc-greedy flag. The GC performed by... (Closed)

Created:
11 years, 4 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove one of the GCs performed by the --gc-greedy flag. The GC performed by CEntryStub before the first call to C, when --gc-greedy is set, caused a bug in calling API callbacks. Committed: http://code.google.com/p/v8/source/detail?r=2706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
11 years, 4 months ago (2009-08-18 09:40:26 UTC) #1
Christian Plesner Hansen
11 years, 4 months ago (2009-08-18 09:53:40 UTC) #2
Lgtm!

Powered by Google App Engine
This is Rietveld 408576698