src/ia32/codegen-ia32.cc - Issue 171104: Remove one of the GCs performed by the --gc-greedy flag. The GC performed by...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/codegen-ia32.cc

Issue 171104: Remove one of the GCs performed by the --gc-greedy flag. The GC performed by... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/codegen-ia32.cc

===================================================================

--- src/ia32/codegen-ia32.cc (revision 2703)

+++ src/ia32/codegen-ia32.cc (working copy)

@@ -7671,16 +7671,11 @@

Label throw_out_of_memory_exception;

Label throw_normal_exception;

- // Call into the runtime system. Collect garbage before the call if

- // running with --gc-greedy set.

- if (FLAG_gc_greedy) {

- Failure* failure = Failure::RetryAfterGC(0);

- __ mov(eax, Immediate(reinterpret_cast<int32_t>(failure)));

- }

+ // Call into the runtime system.

GenerateCore(masm, &throw_normal_exception,

&throw_out_of_memory_exception,

frame_type,

- FLAG_gc_greedy,

+ false,

false);

// Do space-specific GC and retry runtime call.

« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »