Issue 171088: Add the UI thread to the list of ChromeThreads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171088: Add the UI thread to the list of ChromeThreads. (Closed)

Created:
11 years, 4 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
jam, abarth-chromium

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add the UI thread to the list of ChromeThreads. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23605

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
M	base/thread.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_thread.h	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_thread.cc	View	1	4 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM! This patch came out much nicer than I would have managed. :)

11 years, 4 months ago (2009-08-18 00:46:28 UTC) #2

jam

11 years, 4 months ago (2009-08-18 19:27:06 UTC) #3

lgtm

On Mon, Aug 17, 2009 at 5:46 PM, <abarth@chromium.org> wrote:

> LGTM!  This patch came out much nicer than I would have managed.  :)
>
>
> http://codereview.chromium.org/171088
>

Expand Messages | Collapse Messages