Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1709004: size --> cellSize adjustment (Closed)

Created:
10 years, 8 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
mrossetti, dhollowa
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

( Retry of http://codereview.chromium.org/1731001 Try servers not helpful since this includes a binary file. Unfortunately I did a --gtest_filter=BookmarkBar\* to self-test which did not include BookmarkButton* tests :-( Only change is "size" to "cellSize" on 2nd to last line of TEST_F(BookmarkButtonCellTest, FolderArrow) ) UI review follow-up for m5 bookmark bar deliverables Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leak-thru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2581 lines, -55 lines) Patch
M chrome/app/nibs/BookmarkBarFolderWindow.xib View 22 chunks +57 lines, -50 lines 0 comments Download
A chrome/app/theme/menu_hierarchy_arrow.pdf View 1 chunk +2369 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_controller.mm View 7 chunks +32 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_window.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_window.mm View 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_window_unittest.mm View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_button_cell.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_button_cell.mm View 4 chunks +47 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_button_cell_unittest.mm View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
John Grabowski
10 years, 8 months ago (2010-04-21 06:17:35 UTC) #1
John Grabowski
10 years, 8 months ago (2010-04-21 06:18:01 UTC) #2
mrossetti
LGTM
10 years, 8 months ago (2010-04-21 16:18:16 UTC) #3
dhollowa
LGTM, thought the "leak-thru" comment in the description is no longer accurate, correct?
10 years, 8 months ago (2010-04-21 16:25:24 UTC) #4
dhollowa
On 2010/04/21 16:25:24, dhollowa wrote: > LGTM, thought the "leak-thru" comment in the description is ...
10 years, 8 months ago (2010-04-21 16:25:48 UTC) #5
John Grabowski
10 years, 8 months ago (2010-04-21 16:29:40 UTC) #6
Right; no more leaking.

Comment was updated in the code.

jrg


On Wed, Apr 21, 2010 at 9:25 AM, <dhollowa@chromium.org> wrote:

> LGTM, thought the "leak-thru" comment in the description is no longer
> accurate,
> correct?
>
>
> http://codereview.chromium.org/1709004/show
>

Powered by Google App Engine
This is Rietveld 408576698