UI review follow-up for m5 bookmark bar deliverables...

UI review follow-up for m5 bookmark bar deliverables

Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
  works; has a little leak-thru)

BUG=42026
TEST=see description

xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView 
 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45151

[mrossetti, 2010-04-20 23:15:30]

LGTM

http://codereview.chromium.org/1731001/diff/5001/3005
File chrome/browser/cocoa/bookmark_button_cell.mm (right):

http://codereview.chromium.org/1731001/diff/5001/3005#newcode201
chrome/browser/cocoa/bookmark_button_cell.mm:201: // Override cell drawing to
add a "more..." arrow like a real menu.
It's not really a 'more...' arrow, but a 'submenu' arrow.

http://codereview.chromium.org/1731001/diff/5001/3006
File chrome/browser/cocoa/bookmark_button_cell_unittest.mm (right):

http://codereview.chromium.org/1731001/diff/5001/3006#newcode148
chrome/browser/cocoa/bookmark_button_cell_unittest.mm:148: 
Extra line.

[dhollowa, 2010-04-21 00:22:27]

I believe that if you enable the "Draw Background" flag on the
BookmarkBarFolderWindowScrollView in the nib you'll be able to stop the
scrollWheel leaks. Yes?

[dhollowa, 2010-04-21 00:38:23]

LGTM with nit and question about scroll wheel leaks.

http://codereview.chromium.org/1731001/diff/5001/3012
File chrome/browser/cocoa/bookmark_bar_folder_window.mm (right):

http://codereview.chromium.org/1731001/diff/5001/3012#newcode6
chrome/browser/cocoa/bookmark_bar_folder_window.mm:6: #import
"chrome/browser/cocoa/bookmark_bar_folder_controller.h"
nit: This should be move into the lower block after base/scoped_nsobject.h.

[John Grabowski, 2010-04-21 00:53:50]

On 2010/04/21 00:22:27, dhollowa wrote:
> I believe that if you enable the "Draw Background" flag on the
> BookmarkBarFolderWindowScrollView in the nib you'll be able to stop the
> scrollWheel leaks. Yes?

Sigh.  Yes, it works (good insight)... but then I can't trivially round the
bottom corners of the folder window.  Better to avoid a leak than to be round.

[John Grabowski, 2010-04-21 00:54:09]

All feedback applied; final diffs up.
Thanks guys.