Issue 1703015: Some cleanup regarding Siggi's comments on http://codereview.chromium.org/173...

Issue 1703015: Some cleanup regarding Siggi's comments on http://codereview.chromium.org/173... (Closed)

Created:
10 years, 8 months ago by robertshield

Modified:
9 years ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Some cleanup regarding Siggi's comments on http://codereview.chromium.org/1733021/show BUG=42660 TEST=none

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+370 lines, -7 lines)			Patch
M	chrome_frame/chrome_frame.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome_frame/crash_reporting/crash_report.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome_frame/crash_reporting/crash_report.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome_frame/exception_barrier.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A	chrome_frame/test/exception_barrier_unittest.cc	View	2	1 chunk	+361 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertshield

On 2010/04/28 15:20:58, Ruðrugis wrote: > lgtm. I included the exception barrier unit test, and ...

10 years, 8 months ago (2010-04-28 17:16:08 UTC) #3

Sigurður Ásgeirsson

lgtm with a couple of nits. Thanks! http://codereview.chromium.org/1703015/diff/6001/7003 File chrome_frame/test/exception_barrier_unittest.cc (right): http://codereview.chromium.org/1703015/diff/6001/7003#newcode73 chrome_frame/test/exception_barrier_unittest.cc:73: * null ...

10 years, 8 months ago (2010-04-28 20:15:25 UTC) #4

robertshield

10 years, 7 months ago (2010-05-06 18:52:27 UTC) #5

Had dangling draft comments on this review. Emailing them out to confuse people.

http://codereview.chromium.org/1703015/diff/6001/7003
File chrome_frame/test/exception_barrier_unittest.cc (right):

http://codereview.chromium.org/1703015/diff/6001/7003#newcode73
chrome_frame/test/exception_barrier_unittest.cc:73: * null = '\0';
On 2010/04/28 20:15:25, Ruðrugis wrote:
> wonky WS.

Done.

http://codereview.chromium.org/1703015/diff/6001/7003#newcode285
chrome_frame/test/exception_barrier_unittest.cc:285: bool GetStackLimits() {
On 2010/04/28 20:15:25, Ruðrugis wrote:
> woot? Remove this, as it's unused?

removed.

Expand Messages | Collapse Messages