chrome_frame/crash_reporting/crash_report.cc - Issue 1703015: Some cleanup regarding Siggi's comments on http://codereview.chromium.org/173...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/crash_reporting/crash_report.cc

Issue 1703015: Some cleanup regarding Siggi's comments on http://codereview.chromium.org/173... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/crash_reporting/crash_report.cc

===================================================================

--- chrome_frame/crash_reporting/crash_report.cc (revision 45764)

+++ chrome_frame/crash_reporting/crash_report.cc (working copy)

@@ -12,10 +12,12 @@

// TODO(joshia): factor out common code with chrome used for crash reporting

const wchar_t kGoogleUpdatePipeName[] = L"\\\\.\\pipe\\GoogleCrashServices\\";

-static google_breakpad::ExceptionHandler * g_breakpad = NULL;

+// This lock protects against concurrent access to g_breakpad.

static Lock g_breakpad_lock;

+static google_breakpad::ExceptionHandler* g_breakpad = NULL;

-// These minidump flag combinations have been tested safe agains the

+// These minidump flag combinations have been tested safe against the

// DbgHelp.dll version that ships with Windows XP SP2.

const MINIDUMP_TYPE kSmallDumpType = static_cast<MINIDUMP_TYPE>(

MiniDumpWithProcessThreadData | // Get PEB and TEB.

« no previous file with comments | « chrome_frame/crash_reporting/crash_report.h ('k') | chrome_frame/exception_barrier.cc » ('j') | no next file with comments »