Hack to work around bad cygwin, TMP and svn interaction.

Hack to work around bad cygwin, TMP and svn interaction.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45852

[Erik does not do reviews, 2010-04-28 20:12:43]

LGTM

On Wed, Apr 28, 2010 at 1:00 PM,  <maruel@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Description:
> Hack to work around bad cygwin, TMP and svn interaction.
>
> Please review this at http://codereview.chromium.org/1702012/show
>
> Affected files:
>  M trychange.py
>
>
> Index: trychange.py
> diff --git a/trychange.py b/trychange.py
> index
>
1a87028f02f161d8cafad83df94805aab57449b7..2e5239a9e70fbf84a4d17bf77b1754c1bf429fdc
> 100755
> --- a/trychange.py
> +++ b/trychange.py
> @@ -353,7 +353,16 @@ def _SendChangeSVN(options):
>       gclient_utils.FileWrite(full_path, options.diff, 'wb')
>
>       # Committing it will trigger a try job.
> -      command = ['svn', 'import', '-q', temp_dir, options.svn_repo,
> '--file',
> +      if sys.platform == "cygwin":
> +        # Small chromium-specific issue here:
> +        # git-try uses /usr/bin/python on cygwin but svn.bat will be used
> +        # instead of /usr/bin/svn by default. That causes bad things(tm)
> since
> +        # Windows' svn.exe has no clue about cygwin paths. Hence force to
> use
> +        # the cygwin version in this particular context.
> +        exe = "/usr/bin/svn"
> +      else:
> +        exe = "svn"
> +      command = [exe, 'import', '-q', temp_dir, options.svn_repo, '--file',
>                  temp_file.name]
>       gclient_utils.CheckCall(command)
>     except gclient_utils.CheckCallError, e:
>
>
>