Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: trychange.py

Issue 1702012: Hack to work around bad cygwin, TMP and svn interaction. (Closed)
Patch Set: Final version Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 1a87028f02f161d8cafad83df94805aab57449b7..2e5239a9e70fbf84a4d17bf77b1754c1bf429fdc 100755
--- a/trychange.py
+++ b/trychange.py
@@ -353,7 +353,16 @@ def _SendChangeSVN(options):
gclient_utils.FileWrite(full_path, options.diff, 'wb')
# Committing it will trigger a try job.
- command = ['svn', 'import', '-q', temp_dir, options.svn_repo, '--file',
+ if sys.platform == "cygwin":
+ # Small chromium-specific issue here:
+ # git-try uses /usr/bin/python on cygwin but svn.bat will be used
+ # instead of /usr/bin/svn by default. That causes bad things(tm) since
+ # Windows' svn.exe has no clue about cygwin paths. Hence force to use
+ # the cygwin version in this particular context.
+ exe = "/usr/bin/svn"
+ else:
+ exe = "svn"
+ command = [exe, 'import', '-q', temp_dir, options.svn_repo, '--file',
temp_file.name]
gclient_utils.CheckCall(command)
except gclient_utils.CheckCallError, e:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698