Issue 1702009: Add a gyp flag for disabling sse2. This makes it easier for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1702009: Add a gyp flag for disabling sse2. This makes it easier for (Closed)

Created:
10 years, 8 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add a gyp flag for disabling sse2. This makes it easier for distros to disable sse2. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45777

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	build/common.gypi	View		4 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

10 years, 8 months ago (2010-04-27 14:07:08 UTC) #2

LGTM.

Let's just land something like this and stop going around in circles on this
issue.

http://codereview.chromium.org/1702009/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/1702009/diff/1/2#newcode925
build/common.gypi:925: '-march=pentium4',
This knocks out rather more than just SSE2, but whatever.

Expand Messages | Collapse Messages