Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: build/common.gypi

Issue 1702009: Add a gyp flag for disabling sse2. This makes it easier for (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 163cf9ba841162ebf608e97f858596600941033e..c522c852194f6b6a03164aad0ac4fed9d3d651c9 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -106,6 +106,9 @@
# The system root for cross-compiles. Default: none.
'sysroot%': '',
+
+ # On Linux, we build with sse2 for Chromium builds.
+ 'disable_sse2%': 0,
},
# Define branding and buildtype on the basis of their settings within the
@@ -123,6 +126,7 @@
'armv7%': '<(armv7)',
'arm_neon%': '<(arm_neon)',
'sysroot%': '<(sysroot)',
+ 'disable_sse2%': '<(disable_sse2)',
# The release channel that this build targets. This is used to restrict
# channel-specific build options, like which installer packages to create.
@@ -916,7 +920,7 @@
# compiler optimized the code, since the value is always kept
# in its specified precision.
'conditions': [
- ['branding=="Chromium"', {
+ ['branding=="Chromium" and disable_sse2==0', {
'cflags': [
'-march=pentium4',
agl 2010/04/27 14:07:08 This knocks out rather more than just SSE2, but wh
'-msse2',
@@ -927,7 +931,7 @@
# benefit comes from sse2 so this setting allows ChromeOS
# to build on other CPUs. In the future -march=atom would help
# but requires a newer compiler.
- ['chromeos==1', {
+ ['chromeos==1 and disable_sse2==0', {
'cflags': [
'-msse2',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698