Issue 17014: Remove compatibility #defines in string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17014: Remove compatibility #defines in string_util.h (Closed)

Created:
11 years, 11 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove compatibility #defines in string_util.h

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -15 lines)			Patch
M	base/string_util.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/navigation_controller_unittest.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/test/chrome_plugin/test_chrome_plugin.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/base/cookie_monster.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

According to my git grep it's all what needed to be changed. I didn't test ...

11 years, 11 months ago (2008-12-30 10:45:56 UTC) #1

Paweł Hajdan Jr.

Try job finished successfully on Win (thanks, Dean).

11 years, 11 months ago (2008-12-30 12:25:03 UTC) #2

Dean McNamee

11 years, 11 months ago (2008-12-30 13:12:23 UTC) #3

LGTM, the try failed on Mac, but I couldn't tell if it was this change or
something else.

On 2008/12/30 12:25:03, Paweł Hajdan Jr. wrote:
> Try job finished successfully on Win (thanks, Dean).

Expand Messages | Collapse Messages