Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5782)

Unified Diff: chrome/browser/navigation_controller_unittest.cc

Issue 17014: Remove compatibility #defines in string_util.h (Closed)
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/string_util.h ('k') | chrome/test/chrome_plugin/test_chrome_plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/navigation_controller_unittest.cc
diff --git a/chrome/browser/navigation_controller_unittest.cc b/chrome/browser/navigation_controller_unittest.cc
index b2e21cfc183b7c353d868a3265b2fd2d719cb4f4..8ffd331c1df906cf8484f2da5c2cb04fc2d9e1e8 100644
--- a/chrome/browser/navigation_controller_unittest.cc
+++ b/chrome/browser/navigation_controller_unittest.cc
@@ -1168,7 +1168,8 @@ TEST_F(NavigationControllerTest, EnforceMaxNavigationCount) {
char buffer[128];
// Load up to the max count, all entries should be there.
for (url_index = 0; url_index < kMaxEntryCount; url_index++) {
- SNPrintF(buffer, 128, (scheme1() + "://www.a.com/%d").c_str(), url_index);
+ base::snprintf(buffer, 128, (scheme1() + "://www.a.com/%d").c_str(),
+ url_index);
GURL url(buffer);
contents->controller()->LoadURL(url, GURL(), PageTransition::TYPED);
contents->CompleteNavigationAsRenderer(url_index, url);
@@ -1180,7 +1181,8 @@ TEST_F(NavigationControllerTest, EnforceMaxNavigationCount) {
PrunedListener listener(contents->controller());
// Navigate some more.
- SNPrintF(buffer, 128, (scheme1() + "://www.a.com/%d").c_str(), url_index);
+ base::snprintf(buffer, 128, (scheme1() + "://www.a.com/%d").c_str(),
+ url_index);
GURL url(buffer);
contents->controller()->LoadURL(url, GURL(), PageTransition::TYPED);
contents->CompleteNavigationAsRenderer(url_index, url);
@@ -1198,7 +1200,8 @@ TEST_F(NavigationControllerTest, EnforceMaxNavigationCount) {
// More navigations.
for (int i = 0; i < 3; i++) {
- SNPrintF(buffer, 128, (scheme1() + "://www.a.com/%d").c_str(), url_index);
+ base::snprintf(buffer, 128, (scheme1() + "://www.a.com/%d").c_str(),
+ url_index);
url = GURL(buffer);
contents->controller()->LoadURL(url, GURL(), PageTransition::TYPED);
contents->CompleteNavigationAsRenderer(url_index, url);
« no previous file with comments | « base/string_util.h ('k') | chrome/test/chrome_plugin/test_chrome_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698