Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1697002: Added facility to stub log and check. It is still not ideal but workable. (Closed)

Created:
10 years, 8 months ago by alokp
Modified:
9 years, 6 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Added facility to stub log and check. It is still not ideal but workable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M gpu/command_buffer/client/cmd_buffer_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/logging.h View 2 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alokp
10 years, 8 months ago (2010-04-20 21:08:56 UTC) #1
apatrick_chromium
LGTM
10 years, 8 months ago (2010-04-20 21:13:12 UTC) #2
David Springer
Were you able to build the trusted_gpu lib in the NaCl SDK?
10 years, 8 months ago (2010-04-20 22:17:28 UTC) #3
alokp1
10 years, 8 months ago (2010-04-20 22:23:49 UTC) #4
I have not tried the nacl sdk. You might need to use the new #define instead.

On Tue, Apr 20, 2010 at 4:17 PM,  <dspringer@google.com> wrote:
> Were you able to build the trusted_gpu lib in the NaCl SDK?
>
> http://codereview.chromium.org/1697002/show
>

Powered by Google App Engine
This is Rietveld 408576698