Issue 1695027: Change TestWebViewDelegate::createView in include WebWindowFeatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1695027: Change TestWebViewDelegate::createView in include WebWindowFeatures (Closed)

Created:
10 years, 7 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Change TestWebViewDelegate::createView in include WebWindowFeatures This should have made it in with http://codereview.chromium.org/1758004/show (note change to RenderView) which is in anticipation of a webkit patch to actually change the ChromeClient to use the new signature. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46024

Created: 10 years, 7 months ago

		Unified diffs	Side-by-side diffs	Stats (+16 lines, -0 lines)
	M	webkit/tools/test_shell/test_webview_delegate.h	View	2 chunks	+6 lines, -0 lines	0 comments
	M	webkit/tools/test_shell/test_webview_delegate.cc	View	3 chunks	+10 lines, -0 lines	0 comments

Total messages: 1 (0 generated)

lgtm