Chromium Code Reviews

Unified Diff: webkit/tools/test_shell/test_webview_delegate.cc

Issue 1695027: Change TestWebViewDelegate::createView in include WebWindowFeatures (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: pre commit Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « webkit/tools/test_shell/test_webview_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_webview_delegate.cc
diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc
index 408c0b09ddb3a0eaa35d81267633483bb7e5be6c..2cffc293d75570a39e9907802af24b090c47f295 100644
--- a/webkit/tools/test_shell/test_webview_delegate.cc
+++ b/webkit/tools/test_shell/test_webview_delegate.cc
@@ -41,6 +41,7 @@
#include "third_party/WebKit/WebKit/chromium/public/WebURLRequest.h"
#include "third_party/WebKit/WebKit/chromium/public/WebURLResponse.h"
#include "third_party/WebKit/WebKit/chromium/public/WebView.h"
+#include "third_party/WebKit/WebKit/chromium/public/WebWindowFeatures.h"
#include "webkit/appcache/web_application_cache_host_impl.h"
#include "webkit/glue/glue_serialize.h"
#include "webkit/glue/plugins/webplugin_impl.h"
@@ -106,6 +107,7 @@ using WebKit::WebURLError;
using WebKit::WebURLRequest;
using WebKit::WebURLResponse;
using WebKit::WebWidget;
+using WebKit::WebWindowFeatures;
using WebKit::WebWorker;
using WebKit::WebWorkerClient;
using WebKit::WebView;
@@ -309,7 +311,15 @@ void TestWebViewDelegate::SetAuthorAndUserStylesEnabled(bool is_enabled) {
// WebViewClient -------------------------------------------------------------
+// TODO(rafaelw): remove when
+// WebViewClient::createView(WebFrame,WebWindowFeatures) lands.
WebView* TestWebViewDelegate::createView(WebFrame* creator) {
+ return createView(creator, WebWindowFeatures());
+}
+
+WebView* TestWebViewDelegate::createView(
+ WebFrame* creator,
+ const WebWindowFeatures& window_features) {
return shell_->CreateWebView();
}
« no previous file with comments | « webkit/tools/test_shell/test_webview_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine