Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 1695023: linux: unify proxy config docs (Closed)

Created:
10 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

linux: unify proxy config docs We had some info in the man page and other info in the about page. This change makes the about page refer to the man page, and updates the man page with missing info. While I'm at it, make the HTML slightly prettier. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45773

Patch Set 1 #

Patch Set 2 : -linux #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +9 lines, -18 lines 0 comments Download
M chrome/app/resources/manpage.1.in View 2 chunks +13 lines, -2 lines 2 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
http://i.imgur.com/J1rXO.png
10 years, 8 months ago (2010-04-28 01:34:20 UTC) #1
Evan Martin
(The incorrect name to run "man" on is a debug-only issue and works for real ...
10 years, 8 months ago (2010-04-28 01:34:55 UTC) #2
eroman
lgtm
10 years, 8 months ago (2010-04-28 01:38:29 UTC) #3
eroman
http://codereview.chromium.org/1695023/diff/4001/2003 File chrome/app/resources/manpage.1.in (right): http://codereview.chromium.org/1695023/diff/4001/2003#newcode55 chrome/app/resources/manpage.1.in:55: Defined and empty means "autodetect proxy settings", while non-empty ...
10 years, 8 months ago (2010-04-28 01:41:26 UTC) #4
Evan Martin
10 years, 8 months ago (2010-04-28 01:48:22 UTC) #5
http://codereview.chromium.org/1695023/diff/4001/2003
File chrome/app/resources/manpage.1.in (right):

http://codereview.chromium.org/1695023/diff/4001/2003#newcode55
chrome/app/resources/manpage.1.in:55: Defined and empty means "autodetect proxy
settings", while non-empty
On 2010/04/28 01:41:26, eroman wrote:
> Are you sure about this?
> 
> I thought you needed to pass --proxy-auto-detect to trigger autodetect.

Oh, I got overzealous in merging docs.  The old docs should stay!.  (I see
proxy-auto-detect directly above!)

Powered by Google App Engine
This is Rietveld 408576698