Issue 1692005: 2nd attempt to land http://codereview.chromium.org/1676002 for njw...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1692005: 2nd attempt to land http://codereview.chromium.org/1676002 for njw... (Closed)

Created:
10 years, 8 months ago by Charlie Lee

Modified:
9 years, 7 months ago

Reviewers:
Nathan Williams

CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

2nd attempt to land http://codereview.chromium.org/1676002 for njw WifiConfigView - support networks with 802.1x authentication by prompting the user to enter an ID, select a certificate/private key file, and enter a password for the key file, if any. Pass these values down the stack into ConnectToWifiNetwork(). TEST=Compiles and login dialog shows new fields when security is 802.1x. BUG=none TBR=njw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45229

Patch Set 1 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+166 lines, -48 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_network_library.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1 chunk	+15 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/network_screen_browsertest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/options/internet_page_view.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_config_view.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.h	View	5 chunks	+18 lines, -1 line	0 comments	Download
	chrome/browser/chromeos/options/wifi_config_view.cc	View	8 chunks	+97 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages