Issue 1673006: Use an object to control the blocking of the constant pool...

Issue 1673006: Use an object to control the blocking of the constant pool... (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use an object to control the blocking of the constant pool Instead of indicating for how many instructions the constant pool needs to be blocked the constant pool is now blocked while at least one instance of ScopedConstPoolBlocker exists. Committed: http://code.google.com/p/v8/source/detail?r=4456

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -71 lines)			Patch
M	src/arm/assembler-arm.h	View	1 2 3	3 chunks	+19 lines, -5 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View	1	3 chunks	+10 lines, -9 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 2 3	1 chunk	+23 lines, -23 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 2 3	1 chunk	+24 lines, -23 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 2 3	1 chunk	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

STV! http://codereview.chromium.org/1673006/diff/15001/7002 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/1673006/diff/15001/7002#newcode929 src/arm/assembler-arm.h:929: class ScopedConstPoolBlocker { I think we usually call ...

10 years, 8 months ago (2010-04-21 09:28:50 UTC) #2

Søren Thygesen Gjesse

10 years, 8 months ago (2010-04-21 09:41:37 UTC) #3

http://codereview.chromium.org/1673006/diff/15001/7002
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/1673006/diff/15001/7002#newcode929
src/arm/assembler-arm.h:929: class ScopedConstPoolBlocker {
On 2010/04/21 09:28:50, Mads Ager wrote:
> I think we usually call these classes something ending in Scope:
> NoHandleAllocationScope, HandleScope, ZoneScope. Let's call this
> BlockConstPoolScope?

Done.

http://codereview.chromium.org/1673006/diff/15001/7002#newcode1039
src/arm/assembler-arm.h:1039: int no_const_pool_before_;  // Block emission
before this pc offset.
On 2010/04/21 09:28:50, Mads Ager wrote:
> Can we get rid of this one or is it still used?

Not at the moment. It is still used internally in the assembler to control the
const pool scope blocking cross methods of the assembler. However it's use is
not exposed outside the assembler.

Expand Messages | Collapse Messages