Issue 1673005: Add missing smi check in IC for nonexistent properties....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1673005: Add missing smi check in IC for nonexistent properties.... (Closed)

Created:
10 years, 8 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, antonm

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add missing smi check in IC for nonexistent properties. Add regression test. BUG=v8:681 Committed: http://code.google.com/p/v8/source/detail?r=4446

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -0 lines)
M	src/arm/stub-cache-arm.cc	View	1 chunk	+4 lines, -0 lines	1 comment
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+4 lines, -0 lines	0 comments
M	src/x64/stub-cache-x64.cc	View	1 chunk	+3 lines, -0 lines	0 comments
A	test/mjsunit/regress/regress-681.js	View	1 chunk	+44 lines, -0 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

10 years, 8 months ago (2010-04-20 11:28:38 UTC) #3

http://codereview.chromium.org/1673005/diff/1/5
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/1673005/diff/1/5#newcode1425
src/arm/stub-cache-arm.cc:1425: __ b(eq, &miss);
drive by comment: there is BranchOnSmi macro

Expand Messages | Collapse Messages