Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 1673005: Add missing smi check in IC for nonexistent properties.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1402 matching lines...) Expand 10 before | Expand all | Expand 10 after
1413 // ----------- S t a t e ------------- 1413 // ----------- S t a t e -------------
1414 // -- r2 : name 1414 // -- r2 : name
1415 // -- lr : return address 1415 // -- lr : return address
1416 // -- [sp] : receiver 1416 // -- [sp] : receiver
1417 // ----------------------------------- 1417 // -----------------------------------
1418 Label miss; 1418 Label miss;
1419 1419
1420 // Load receiver. 1420 // Load receiver.
1421 __ ldr(r0, MemOperand(sp, 0)); 1421 __ ldr(r0, MemOperand(sp, 0));
1422 1422
1423 // Check that receiver is not a smi.
1424 __ tst(r0, Operand(kSmiTagMask));
1425 __ b(eq, &miss);
antonm 2010/04/20 11:28:38 drive by comment: there is BranchOnSmi macro
1426
1423 // Check the maps of the full prototype chain. 1427 // Check the maps of the full prototype chain.
1424 CheckPrototypes(object, r0, last, r3, r1, name, &miss); 1428 CheckPrototypes(object, r0, last, r3, r1, name, &miss);
1425 1429
1426 // If the last object in the prototype chain is a global object, 1430 // If the last object in the prototype chain is a global object,
1427 // check that the global property cell is empty. 1431 // check that the global property cell is empty.
1428 if (last->IsGlobalObject()) { 1432 if (last->IsGlobalObject()) {
1429 Object* cell = GenerateCheckPropertyCell(masm(), 1433 Object* cell = GenerateCheckPropertyCell(masm(),
1430 GlobalObject::cast(last), 1434 GlobalObject::cast(last),
1431 name, 1435 name,
1432 r1, 1436 r1,
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
1951 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET); 1955 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET);
1952 1956
1953 // Return the generated code. 1957 // Return the generated code.
1954 return GetCode(); 1958 return GetCode();
1955 } 1959 }
1956 1960
1957 1961
1958 #undef __ 1962 #undef __
1959 1963
1960 } } // namespace v8::internal 1964 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698