Issue 1664: Put back r1891 with some task deletion disabled to maintain backwards compat...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1664: Put back r1891 with some task deletion disabled to maintain backwards compat... (Closed)

Created:
12 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Put back r1891 with some task deletion disabled to maintain backwards compat and thereby avoid unexpected crashes. r=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1959

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -38 lines)			Patch
M	base/message_loop.h	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download
M	base/message_loop.cc	View	1 2	4 chunks	+56 lines, -36 lines	0 comments	Download
M	base/message_loop_unittest.cc	View		2 chunks	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

12 years, 3 months ago (2008-09-09 17:51:27 UTC) #2

I tried to review it from a perspective or retaining current semantics, and
noticed the item below.

WDYT?

Jim

http://codereview.chromium.org/1664/diff/1/4
File base/message_loop.cc (right):

http://codereview.chromium.org/1664/diff/1/4#newcode343
Line 343: delete task;
This causes out-of-fifo-order deletion of delayed tasks.  If you want to
preserve semantics of existing code, you should instead push the delayed task
onto the delayed work queue, so that they are all deleted in time/fifo ordering.

I suspect there are some "catch all" cleanup tasks that are intended to run if
the real work is not done first by a previously scheduled timer task.  This
out-of-order stuff could be causing the crashes.

Expand Messages | Collapse Messages