port some parts of webkit/glue/plugins/test to Linux...

webkit/glue/plugins/test/plugin_test.cc

Index: webkit/glue/plugins/test/plugin_test.cc
===================================================================
--- webkit/glue/plugins/test/plugin_test.cc	(revision 2052)
+++ webkit/glue/plugins/test/plugin_test.cc	(working copy)
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/string_util.h"
 #include "webkit/glue/plugins/test/plugin_test.h"
 #include "webkit/glue/plugins/test/npapi_constants.h"
 
@@ -32,7 +33,7 @@
 // end up using libicu, which is a string of dependencies we don't
 // want.
 
-inline BYTE toHex(const BYTE &x) {
+inline unsigned char toHex(const unsigned char &x) {
     return x > 9 ? x + 55: x + 48;

[Mark Mentovai, 2008/09/16 17:53:36]

Existing code, but I think this is far less obtuse as:

return x > 9 ? (x + 'A' - 10) : (x + '0');

and the indent should be two spaces.

 }
 
@@ -88,7 +89,7 @@
 const char *PluginTest::GetArgValue(const char *name, const int16 argc,
                                     const char *argn[], const char *argv[]) {
   for (int idx = 0; idx < argc; idx++)
-    if (_stricmp(argn[idx], name) == 0)
+    if (base::strcasecmp(argn[idx], name) == 0)
       return argv[idx];
   return NULL;
 }